mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-05 18:58:22 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
72 lines
2.2 KiB
C++
72 lines
2.2 KiB
C++
// Copyright 2018 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "snapshot/sanitized/sanitization_information.h"
|
|
|
|
#include "base/stl_util.h"
|
|
#include "build/build_config.h"
|
|
#include "gtest/gtest.h"
|
|
#include "util/misc/from_pointer_cast.h"
|
|
#include "util/process/process_memory_linux.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
class WhitelistTest : public testing::Test {
|
|
public:
|
|
void SetUp() override {
|
|
ASSERT_TRUE(memory_.Initialize(getpid()));
|
|
#if defined(ARCH_CPU_64_BITS)
|
|
ASSERT_TRUE(range_.Initialize(&memory_, true));
|
|
#else
|
|
ASSERT_TRUE(range_.Initialize(&memory_, false));
|
|
#endif
|
|
}
|
|
|
|
protected:
|
|
bool ReadWhitelist(const char* const* address) {
|
|
return ReadAnnotationsWhitelist(
|
|
range_, FromPointerCast<VMAddress>(address), &whitelist_);
|
|
}
|
|
|
|
ProcessMemoryLinux memory_;
|
|
ProcessMemoryRange range_;
|
|
std::vector<std::string> whitelist_;
|
|
};
|
|
|
|
const char* const kEmptyWhitelist[] = {nullptr};
|
|
|
|
TEST_F(WhitelistTest, EmptyWhitelist) {
|
|
ASSERT_TRUE(ReadWhitelist(kEmptyWhitelist));
|
|
EXPECT_EQ(whitelist_, std::vector<std::string>());
|
|
}
|
|
|
|
const char* const kNonEmptyWhitelist[] = {"string1",
|
|
"another_string",
|
|
"",
|
|
nullptr};
|
|
|
|
TEST_F(WhitelistTest, NonEmptyWhitelist) {
|
|
ASSERT_TRUE(ReadWhitelist(kNonEmptyWhitelist));
|
|
ASSERT_EQ(whitelist_.size(), base::size(kNonEmptyWhitelist) - 1);
|
|
for (size_t index = 0; index < base::size(kNonEmptyWhitelist) - 1; ++index) {
|
|
EXPECT_EQ(whitelist_[index], kNonEmptyWhitelist[index]);
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|