Mark Mentovai 9168ba47ac Fix minidump_module_writer_test 32-bit x86 build.
time_t is a typedef for long on Mac OS X. In 32-bit x86 (ILP32), long is
a signed 32-bit quantity, and its range does not contain the range of
uint32_t, used to store times in time_t fashion in minidump files. A
cast is necessary to make these EXPECT_* macros do the right thing. This
is not a problem in x86_64 (LP64) where long is a signed 64-bit
quantity, which does contain the range of uint32_t.

clang’s error was “error: comparison of integers of different signs:
'const long' and 'const unsigned int' [-Werror,-Wsign-compare]”

BUG=
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/491023005
2014-08-20 18:32:06 -04:00
2014-07-30 23:24:58 -04:00
2014-08-20 18:30:19 -04:00
2014-07-30 23:24:58 -04:00
2014-08-20 15:18:55 -04:00
2014-08-20 13:58:42 -04:00
2014-07-30 23:24:58 -04:00
2014-07-30 23:24:58 -04:00
2014-07-30 23:24:58 -04:00
2014-07-30 23:24:58 -04:00
2014-08-20 18:30:19 -04:00
2014-07-30 23:24:58 -04:00
2014-07-30 23:24:58 -04:00
Description
A crash-reporting system
Apache-2.0 23 MiB
Languages
C++ 92.5%
Objective-C++ 2.5%
C 2%
Python 1.8%
Assembly 0.9%
Other 0.3%