mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:32:35 +08:00
90054edf62
hanging_program.exe is used by crash_other_program.exe, which is in turn used by end_to_end_test.py. It hangs by loading loader_lock_dll.dll, which squats in its entry point function while the loader lock is held. hanging_program.exe needs to do some work in its Thread1() before the loader lock is taken (a SetThreadPriority() call), and needs to do some work in its main thread once the loader lock is held (it needs to signal crash_other_program.exe that it’s successfully wedged itself). Previously, proper synchronization was not provided. A 1-second Sleep() was used to wait for the loader lock to be taken. Thread1() pre-work was only achieved before the loader lock was taken by sheer luck. Things didn’t always work out so nicely. This uses an event handle to provide synchronization. An environment variable is used to pass the handle to loader_lock_dll.dll, because there aren’t many better options available. This eliminates both flake and the unnecessary 1-second delay in hanging_program.exe, and since this program runs twice during end_to_end_test.py, it improves that test’s runtime by 2 seconds. Bug: crashpad:197 Test: end_to_end_test.py Change-Id: Ib9883215ef96bed7571464cc68e09b6ab6310ae6 Reviewed-on: https://chromium-review.googlesource.com/700076 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Leonard Mosescu <mosescu@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>