crashpad/handler/win/hanging_program.cc
Mark Mentovai 90054edf62 win: De-flake hanging_program.exe
hanging_program.exe is used by crash_other_program.exe, which is in turn
used by end_to_end_test.py. It hangs by loading loader_lock_dll.dll,
which squats in its entry point function while the loader lock is held.

hanging_program.exe needs to do some work in its Thread1() before the
loader lock is taken (a SetThreadPriority() call), and needs to do some
work in its main thread once the loader lock is held (it needs to signal
crash_other_program.exe that it’s successfully wedged itself).
Previously, proper synchronization was not provided. A 1-second Sleep()
was used to wait for the loader lock to be taken. Thread1() pre-work was
only achieved before the loader lock was taken by sheer luck. Things
didn’t always work out so nicely.

This uses an event handle to provide synchronization. An environment
variable is used to pass the handle to loader_lock_dll.dll, because
there aren’t many better options available. This eliminates both flake
and the unnecessary 1-second delay in hanging_program.exe, and since
this program runs twice during end_to_end_test.py, it improves that
test’s runtime by 2 seconds.

Bug: crashpad:197
Test: end_to_end_test.py
Change-Id: Ib9883215ef96bed7571464cc68e09b6ab6310ae6
Reviewed-on: https://chromium-review.googlesource.com/700076
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Leonard Mosescu <mosescu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-10-04 19:58:56 +00:00

136 lines
3.8 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2016 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include <stdio.h>
#include <windows.h>
#include "base/debug/alias.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "client/crashpad_client.h"
#include "client/crashpad_info.h"
namespace {
DWORD WINAPI Thread1(LPVOID context) {
HANDLE event = context;
// Increase the thread priority as a hacky way to signal to
// crash_other_program.exe that this is the thread to dump.
PCHECK(SetThreadPriority(GetCurrentThread(), THREAD_PRIORITY_ABOVE_NORMAL));
// Let the main thread proceed.
PCHECK(SetEvent(event));
Sleep(INFINITE);
NOTREACHED();
return 0;
}
DWORD WINAPI Thread2(LPVOID dummy) {
Sleep(INFINITE);
NOTREACHED();
return 0;
}
DWORD WINAPI Thread3(LPVOID context) {
// This is a convenient way to pass the event handle to loader_lock_dll.dll.
HANDLE event = context;
PCHECK(SetEnvironmentVariable(
L"CRASHPAD_TEST_DLL_EVENT",
base::UTF8ToUTF16(base::StringPrintf("%p", event)).c_str()));
HMODULE dll = LoadLibrary(L"loader_lock_dll.dll");
if (!dll)
PLOG(FATAL) << "LoadLibrary";
// This call is not expected to return.
if (!FreeLibrary(dll))
PLOG(FATAL) << "FreeLibrary";
NOTREACHED();
return 0;
}
} // namespace
int wmain(int argc, wchar_t* argv[]) {
crashpad::CrashpadClient client;
if (argc == 2) {
if (!client.SetHandlerIPCPipe(argv[1])) {
LOG(ERROR) << "SetHandlerIPCPipe";
return EXIT_FAILURE;
}
} else {
fprintf(stderr, "Usage: %ls <server_pipe_name>\n", argv[0]);
return EXIT_FAILURE;
}
// Make sure this module has a CrashpadInfo structure.
crashpad::CrashpadInfo* crashpad_info =
crashpad::CrashpadInfo::GetCrashpadInfo();
base::debug::Alias(crashpad_info);
HANDLE event = CreateEvent(nullptr,
false, // bManualReset
false,
nullptr);
if (!event) {
PLOG(ERROR) << "CreateEvent";
return EXIT_FAILURE;
}
HANDLE threads[3];
threads[0] = CreateThread(nullptr, 0, Thread1, event, 0, nullptr);
threads[1] = CreateThread(nullptr, 0, Thread2, nullptr, 0, nullptr);
// Wait for Thread1() to complete its work and reach its Sleep() before
// starting the next thread, which will hold the loader lock and potentially
// block any further progress.
if (WaitForSingleObject(event, INFINITE) != WAIT_OBJECT_0) {
PLOG(ERROR) << "WaitForSingleObject";
return EXIT_FAILURE;
}
// Recycle the event handle, which was automatically reset.
threads[2] = CreateThread(nullptr, 0, Thread3, event, 0, nullptr);
// Wait for loader_lock_dll.dll to signal that the loader lock is held and
// wont be released.
if (WaitForSingleObject(event, INFINITE) != WAIT_OBJECT_0) {
PLOG(ERROR) << "WaitForSingleObject";
return EXIT_FAILURE;
}
// Signal to the parent that everything is ready.
fprintf(stdout, " ");
fflush(stdout);
// This is not expected to return.
DWORD count =
WaitForMultipleObjects(arraysize(threads), threads, true, INFINITE);
if (count == WAIT_FAILED) {
PLOG(ERROR) << "WaitForMultipleObjects";
} else {
LOG(ERROR) << "WaitForMultipleObjects: " << count;
}
return EXIT_FAILURE;
}