mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
a869ae18d2
Google Test has recently switched the default death test style from "fast" to "threadsafe". This is a better default, and Chrome will adopt it on all platforms except for Android. In threadsafe mode, the death test in client/simple_string_dictionary_test.cc consistently crashes with the wrong expectation on Mac. Fortunately, breaking the test up into two smaller tests makes the failures go away, and also adds a bit of clarity into what is being tested. Bug: crashpad:221 Change-Id: I2416647948815cfe46a003da8209af8b7278de2a Reviewed-on: https://chromium-review.googlesource.com/936043 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>