mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-09 21:59:50 +08:00
52d766400d
There’s no reason for ProcessReader to own its ProcessMemoryLinux via std::unique_ptr<>. This was discovered in a trunk Clang build, during which a -Wdelete-non-virtual-dtor warning was produced (since Clang r312167). The warning is not produced by earlier Clang versions or by GCC because the “delete” happens in a system header, <memory>, when performed by std::unique_ptr<>. Although ownership via std::unique_ptr<> is no longer used, ProcessMemoryLinux is marked “final” because it ought to be. In file included from ../../snapshot/linux/process_reader.cc:15: In file included from ../../snapshot/linux/process_reader.h:21: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/memory:80: /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/bits/unique_ptr.h:78:2: error: delete called on non-final 'crashpad::ProcessMemoryLinux' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] delete __ptr; ^ /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/bits/unique_ptr.h:268:4: note: in instantiation of member function 'std::default_delete<crashpad::ProcessMemoryLinux>::operator()' requested here get_deleter()(__ptr); ^ ../../snapshot/linux/process_reader.cc:169:16: note: in instantiation of member function 'std::unique_ptr<crashpad::ProcessMemoryLinux, std::default_delete<crashpad::ProcessMemoryLinux> >::~unique_ptr' requested here ProcessReader::ProcessReader() ^ 1 error generated. Change-Id: Ibe9671db429262aca12bbfdf457c8f72cad2f358 Reviewed-on: https://chromium-review.googlesource.com/738530 Reviewed-by: Dave Bort <dbort@google.com> Commit-Queue: Mark Mentovai <mark@chromium.org>
128 lines
4.1 KiB
C++
128 lines
4.1 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#ifndef CRASHPAD_SNAPSHOT_LINUX_PROCESS_READER_H_
|
||
#define CRASHPAD_SNAPSHOT_LINUX_PROCESS_READER_H_
|
||
|
||
#include <sys/time.h>
|
||
#include <sys/types.h>
|
||
|
||
#include <vector>
|
||
|
||
#include "base/macros.h"
|
||
#include "util/linux/address_types.h"
|
||
#include "util/linux/memory_map.h"
|
||
#include "util/linux/ptrace_connection.h"
|
||
#include "util/linux/thread_info.h"
|
||
#include "util/misc/initialization_state_dcheck.h"
|
||
#include "util/posix/process_info.h"
|
||
#include "util/process/process_memory.h"
|
||
#include "util/process/process_memory_linux.h"
|
||
|
||
namespace crashpad {
|
||
|
||
//! \brief Accesses information about another process, identified by a process
|
||
//! ID.
|
||
class ProcessReader {
|
||
public:
|
||
//! \brief Contains information about a thread that belongs to a process.
|
||
struct Thread {
|
||
Thread();
|
||
~Thread();
|
||
|
||
ThreadInfo thread_info;
|
||
LinuxVMAddress stack_region_address;
|
||
LinuxVMSize stack_region_size;
|
||
pid_t tid;
|
||
int sched_policy;
|
||
int static_priority;
|
||
int nice_value;
|
||
|
||
private:
|
||
friend class ProcessReader;
|
||
|
||
bool InitializePtrace(PtraceConnection* connection);
|
||
void InitializeStack(ProcessReader* reader);
|
||
};
|
||
|
||
ProcessReader();
|
||
~ProcessReader();
|
||
|
||
//! \brief Initializes this object.
|
||
//!
|
||
//! This method must be successfully called before calling any other method in
|
||
//! this class and may only be called once.
|
||
//!
|
||
//! \param[in] connection A PtraceConnection to the target process.
|
||
//! \return `true` on success. `false` on failure with a message logged.
|
||
bool Initialize(PtraceConnection* connection);
|
||
|
||
//! \brief Return `true` if the target task is a 64-bit process.
|
||
bool Is64Bit() const { return is_64_bit_; }
|
||
|
||
//! \brief Return the target process' process ID.
|
||
pid_t ProcessID() const { return process_info_.ProcessID(); }
|
||
|
||
//! \brief Return the target process' parent process ID.
|
||
pid_t ParentProcessID() const { return process_info_.ParentProcessID(); }
|
||
|
||
//! \brief Return a memory reader for the target process.
|
||
ProcessMemory* Memory() { return &process_memory_; }
|
||
|
||
//! \brief Return a memory map of the target process.
|
||
MemoryMap* GetMemoryMap() { return &memory_map_; }
|
||
|
||
//! \brief Determines the target process’ start time.
|
||
//!
|
||
//! \param[out] start_time The time that the process started.
|
||
//! \return `true` on success with \a start_time set. Otherwise `false` with a
|
||
//! message logged.
|
||
bool StartTime(timeval* start_time) const;
|
||
|
||
//! \brief Determines the target process’ execution time.
|
||
//!
|
||
//! \param[out] user_time The amount of time the process has executed code in
|
||
//! user mode.
|
||
//! \param[out] system_time The amount of time the process has executed code
|
||
//! in system mode.
|
||
//!
|
||
//! \return `true` on success, `false` on failure, with a warning logged. On
|
||
//! failure, \a user_time and \a system_time will be set to represent no
|
||
//! time spent executing code in user or system mode.
|
||
bool CPUTimes(timeval* user_time, timeval* system_time) const;
|
||
|
||
//! \brief Return a vector of threads that are in the task process. If the
|
||
//! main thread is able to be identified and traced, it will be placed at
|
||
//! index `0`.
|
||
const std::vector<Thread>& Threads();
|
||
|
||
private:
|
||
void InitializeThreads();
|
||
|
||
PtraceConnection* connection_; // weak
|
||
ProcessInfo process_info_;
|
||
MemoryMap memory_map_;
|
||
std::vector<Thread> threads_;
|
||
ProcessMemoryLinux process_memory_;
|
||
bool is_64_bit_;
|
||
bool initialized_threads_;
|
||
InitializationStateDcheck initialized_;
|
||
|
||
DISALLOW_COPY_AND_ASSIGN(ProcessReader);
|
||
};
|
||
|
||
} // namespace crashpad
|
||
|
||
#endif // CRASHPAD_SNAPSHOT_LINUX_PROCESS_READER_H_
|