mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:32:35 +08:00
Mark Mentovai
878400947f
MachOImageSymbolTableReader: permit indirect symbols to exist among
external defined symbols. Indirect symbols remain unsupported. Xcode 5.1 ld64-236.3/src/ld/LinkEditClassic.hpp ld::tool::SymbolTableAtom<>::addGlobal() is responsible for producing symbols found in the extdef portion of the symbol table. It always sets the type to N_ABS, N_SECT, or N_INDR, each with the N_EXT bit set. The N_PEXT bit is never set for non-object files, and we’re not concerned with reading object files. With this change to tolerate N_INDR, I think we’re covering all of the symbol types that we might find ld writing to the extdef portion of the symbol table. https://groups.google.com/a/chromium.org/forum/#!topic/crashpad-dev/k7QkLwO71Zo R=rsesek@chromium.org Review URL: https://codereview.chromium.org/901463004
Description
Languages
C++
92.6%
Objective-C++
2.5%
C
2%
Python
1.7%
Assembly
0.9%
Other
0.3%