mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:00:08 +08:00
8171e6f765
This test was added in https://codereview.chromium.org/1052813002. It was previously checking the timestamp from in-memory module traversal vs. the disk mtime. This is flaky (of course) because it depends on the linker writing the header and closing the file during the same time quantum. So the bots occasionally failed with: [ RUN ] ProcessInfo.Self e:\b\build\slave\chromium_win_dbg\build\crashpad\util\win\process_info_test.cc(86): error: Value of: GetTimestampForModule(GetModuleHandleW(nullptr)) Actual: 1431650338 Expected: modules[0].timestamp Which is: 1431650337 Instead, use imagehlp to pull the timestamp out of the header so that it matches the header value that will be the in-memory timestamp. R=cpu@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1139103003