crashpad/util/posix/symbolic_constants_posix.cc
Mark Mentovai 48b1964d1b Use implicit_cast<> instead of static_cast<> whenever possible.
implicit_cast<> only performs a cast in cases where an implicit
conversion would be possible. It’s even safer than static_cast<> It’s an
“explicit implicit” cast, which is not normally necsesary, but is
frequently required when working with the ?: operator, functions like
std::min() and std::max(), and logging and testing macros.

The public style guide does not mention implicit_cast<> only because it
is not part of the standard library, but would otherwise require it in
these situations. Since base does provide implicit_cast<>, it should be
used whenever possible.

The only uses of static_cast<> not converted to implicit_cast<> are
those that require static_cast<>, such as those that assign an integer
constant to a variable of an enum type.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/700383007
2014-11-06 16:44:38 -05:00

167 lines
3.9 KiB
C++

// Copyright 2014 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "util/posix/symbolic_constants_posix.h"
#include <sys/signal.h>
#include "base/basictypes.h"
#include "base/strings/stringprintf.h"
#include "util/stdlib/string_number_conversion.h"
namespace {
const char* kSignalNames[] = {
nullptr,
#if defined(OS_MACOSX)
// sed -Ene 's/^#define[[:space:]]SIG([[:alnum:]]+)[[:space:]]+[[:digit:]]{1,2}([[:space:]]|$).*/ "\1",/p'
// /usr/include/sys/signal.h
// and fix up by removing the entry for SIGPOLL.
"HUP",
"INT",
"QUIT",
"ILL",
"TRAP",
"ABRT",
"EMT",
"FPE",
"KILL",
"BUS",
"SEGV",
"SYS",
"PIPE",
"ALRM",
"TERM",
"URG",
"STOP",
"TSTP",
"CONT",
"CHLD",
"TTIN",
"TTOU",
"IO",
"XCPU",
"XFSZ",
"VTALRM",
"PROF",
"WINCH",
"INFO",
"USR1",
"USR2",
#elif defined(OS_LINUX)
// sed -Ene 's/^#define[[:space:]]SIG([[:alnum:]]+)[[:space:]]+[[:digit:]]{1,2}([[:space:]]|$).*/ "\1",/p'
// /usr/include/asm-generic/signal.h
// and fix up by removing SIGIOT, SIGLOST, SIGUNUSED, and SIGRTMIN.
"HUP",
"INT",
"QUIT",
"ILL",
"TRAP",
"ABRT",
"BUS",
"FPE",
"KILL",
"USR1",
"SEGV",
"USR2",
"PIPE",
"ALRM",
"TERM",
"STKFLT",
"CHLD",
"CONT",
"STOP",
"TSTP",
"TTIN",
"TTOU",
"URG",
"XCPU",
"XFSZ",
"VTALRM",
"PROF",
"WINCH",
"IO",
"PWR",
"SYS",
#endif
};
#if defined(OS_LINUX)
// NSIG is 64 to account for real-time signals.
static_assert(arraysize(kSignalNames) == 32, "kSignalNames length");
#else
static_assert(arraysize(kSignalNames) == NSIG, "kSignalNames length");
#endif
const char kSigPrefix[] = "SIG";
} // namespace
namespace crashpad {
std::string SignalToString(int signal,
SymbolicConstantToStringOptions options) {
const char* signal_name =
implicit_cast<size_t>(signal) < arraysize(kSignalNames)
? kSignalNames[signal]
: nullptr;
if (!signal_name) {
if (options & kUnknownIsNumeric) {
return base::StringPrintf("%d", signal);
}
return std::string();
}
if (options & kUseShortName) {
return std::string(signal_name);
}
return base::StringPrintf("%s%s", kSigPrefix, signal_name);
}
bool StringToSignal(const base::StringPiece& string,
StringToSymbolicConstantOptions options,
int* signal) {
if ((options & kAllowFullName) || (options & kAllowShortName)) {
bool can_match_full =
(options & kAllowFullName) &&
string.substr(0, strlen(kSigPrefix)).compare(kSigPrefix) == 0;
base::StringPiece short_string =
can_match_full ? string.substr(strlen(kSigPrefix)) : string;
for (int index = 0;
index < implicit_cast<int>(arraysize(kSignalNames));
++index) {
const char* signal_name = kSignalNames[index];
if (!signal_name) {
continue;
}
if (can_match_full && short_string.compare(signal_name) == 0) {
*signal = index;
return true;
}
if ((options & kAllowShortName) && string.compare(signal_name) == 0) {
*signal = index;
return true;
}
}
}
if (options & kAllowNumber) {
return StringToNumber(string, signal);
}
return false;
}
} // namespace crashpad