mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-14 17:30:09 +08:00
50ed179e9a
Use BUILDFLAG(IS_*) instead of defined(OS_*).
This was generated mostly mechnically by performing the following steps:
- sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
-e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
$(git grep -l 'OS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
$(git grep -l '#ifdef BUILDFLAG('
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- gsed -i -z -E -e \
's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- Spot checks to move #include "build/buildflag.h" to the correct parts
of files.
- sed -i '' -E -e \
's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
$(grep -L '^#include "build/build_config.h"$'
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
- Add “clang-format off” around tool usage messages.
- git cl format
- Update mini_chromium to 85ba51f98278 (intermediate step).
TESTING ONLY).
- for f in $(git grep -l '^#include "build/buildflag.h"$'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
cp /tmp/z "${f}"; done
- git cl format
- Update mini_chromium to 735143774c5f (intermediate step).
- Update mini_chromium to f41420eb45fa (as checked in).
- Update mini_chromium to 6e2f204b4ae1 (as checked in).
For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.
This includes an update of mini_chromium to 6e2f204b4ae1:
f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h
Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
125 lines
3.4 KiB
C++
125 lines
3.4 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "test/scoped_temp_dir.h"
|
|
|
|
#include <fcntl.h>
|
|
#include <string.h>
|
|
|
|
#include "base/posix/eintr_wrapper.h"
|
|
#include "build/build_config.h"
|
|
#include "gtest/gtest.h"
|
|
#include "test/errors.h"
|
|
#include "test/file.h"
|
|
|
|
#if BUILDFLAG(IS_POSIX)
|
|
#include <unistd.h>
|
|
#elif BUILDFLAG(IS_WIN)
|
|
#include <direct.h>
|
|
#include <io.h>
|
|
#endif // BUILDFLAG(IS_POSIX)
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
void CreateFile(const base::FilePath& path) {
|
|
#if BUILDFLAG(IS_POSIX)
|
|
int fd = HANDLE_EINTR(creat(path.value().c_str(), 0644));
|
|
ASSERT_GE(fd, 0) << ErrnoMessage("creat") << " " << path.value();
|
|
|
|
// gcc refuses to compile ASSERT_EQ(IGNORE_EINTR(close(fd)), 0).
|
|
int close_rv = IGNORE_EINTR(close(fd));
|
|
ASSERT_EQ(close_rv, 0) << ErrnoMessage("close") << " " << path.value();
|
|
#elif BUILDFLAG(IS_WIN)
|
|
int fd = _wcreat(path.value().c_str(), _S_IREAD | _S_IWRITE);
|
|
ASSERT_GE(fd, 0) << ErrnoMessage("_wcreat") << " " << path.value();
|
|
ASSERT_EQ(_close(fd), 0) << ErrnoMessage("_close") << " " << path.value();
|
|
#else
|
|
#error "Not implemented"
|
|
#endif
|
|
EXPECT_TRUE(FileExists(path));
|
|
}
|
|
|
|
void CreateDirectory(const base::FilePath& path) {
|
|
#if BUILDFLAG(IS_POSIX)
|
|
ASSERT_EQ(mkdir(path.value().c_str(), 0755), 0) << ErrnoMessage("mkdir")
|
|
<< " " << path.value();
|
|
#elif BUILDFLAG(IS_WIN)
|
|
ASSERT_EQ(_wmkdir(path.value().c_str()), 0) << ErrnoMessage("_wmkdir") << " "
|
|
<< path.value();
|
|
#else
|
|
#error "Not implemented"
|
|
#endif
|
|
ASSERT_TRUE(FileExists(path));
|
|
}
|
|
|
|
TEST(ScopedTempDir, Empty) {
|
|
base::FilePath path;
|
|
{
|
|
ScopedTempDir dir;
|
|
path = dir.path();
|
|
EXPECT_TRUE(FileExists(path));
|
|
}
|
|
EXPECT_FALSE(FileExists(path));
|
|
}
|
|
|
|
TEST(ScopedTempDir, WithTwoFiles) {
|
|
base::FilePath parent, file1, file2;
|
|
|
|
{
|
|
ScopedTempDir dir;
|
|
parent = dir.path();
|
|
ASSERT_TRUE(FileExists(parent));
|
|
|
|
file1 = parent.Append(FILE_PATH_LITERAL("test1"));
|
|
CreateFile(file1);
|
|
|
|
file2 = parent.Append(FILE_PATH_LITERAL("test 2"));
|
|
CreateFile(file2);
|
|
}
|
|
|
|
EXPECT_FALSE(FileExists(file1));
|
|
EXPECT_FALSE(FileExists(file2));
|
|
EXPECT_FALSE(FileExists(parent));
|
|
}
|
|
|
|
TEST(ScopedTempDir, WithRecursiveDirectory) {
|
|
base::FilePath parent, file1, child_dir, file2;
|
|
|
|
{
|
|
ScopedTempDir dir;
|
|
parent = dir.path();
|
|
ASSERT_TRUE(FileExists(parent));
|
|
|
|
file1 = parent.Append(FILE_PATH_LITERAL(".first-level file"));
|
|
CreateFile(file1);
|
|
|
|
child_dir = parent.Append(FILE_PATH_LITERAL("subdir"));
|
|
CreateDirectory(child_dir);
|
|
|
|
file2 = child_dir.Append(FILE_PATH_LITERAL("second level file"));
|
|
CreateFile(file2);
|
|
}
|
|
|
|
EXPECT_FALSE(FileExists(file1));
|
|
EXPECT_FALSE(FileExists(file2));
|
|
EXPECT_FALSE(FileExists(child_dir));
|
|
EXPECT_FALSE(FileExists(parent));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|