mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:32:35 +08:00
79177046d3
A couple of the problems related to not having a C++11 library: - You can’t put const elements into a std::vector<>, so CrashReportDatabase::GetPendingReports() and CrashReportDatabase::GetCompletedReports() need to change. There was no data-safety benefit to const elements. - std::string::pop_back() does not exist, another mechanism must be used to trim strings in BreakpadHTTPFormParametersFromMinidump(). One relates to a feature that does not exist in 10.6: - The O_CLOEXEC flag to open() was introduced in 10.7. Although it would be possible to use fcntl(..., F_SETFD, FD_CLOEXEC) on 10.6, the O_CLOEXEC behavior is just removed from CrashReportDatabaseMac::ObtainReportLock(), in line with other open() calls in Crashpad. And one was a real bug: - #define __STDC_FORMAT_MACROS before #including <inttypes.h> to get format macros like SCNx32, used in UUID::InitializeFromString(). TEST=* (gyp_crashpad.py -Dmac_sdk=10.6 -Dmac_deployment_target=10.6) R=rsesek@chromium.org Review URL: https://codereview.chromium.org/987693004