crashpad/util/misc/arraysize_unsafe_test.cc
Mark Mentovai 72fbc56e58 MSVC++ fix: Don’t declare local[0] arrays for ARRAYSIZE_UNSAFE test
After f83530bf9a0b, while compiling arraysize_unsafe_test.cc:

…\crashpad\util\misc\arraysize_unsafe_test.cc(24) : error C2466: cannot allocate an array of constant size 0
…\crashpad\util\misc\arraysize_unsafe_test.cc(24) : error C2133: 'c0' : unknown size
…\crashpad\util\misc\arraysize_unsafe_test.cc(25) : error C2070: 'char []': illegal sizeof operand
…\crashpad\util\misc\arraysize_unsafe_test.cc(36) : error C2466: cannot allocate an array of constant size 0
…\crashpad\util\misc\arraysize_unsafe_test.cc(36) : error C2133: 'i0' : unknown size
…\crashpad\util\misc\arraysize_unsafe_test.cc(37) : error C2070: 'int []': illegal sizeof operand
…\crashpad\util\misc\arraysize_unsafe_test.cc(61) : error C2466: cannot allocate an array of constant size 0
…\crashpad\util\misc\arraysize_unsafe_test.cc(61) : error C2133: 's0' : unknown size
…\crashpad\util\misc\arraysize_unsafe_test.cc(62) : error C2070: 'crashpad::test::`anonymous-namespace'::ArraySizeUnsafe_ArraySizeUnsafe_Test::TestBody::S []': illegal sizeof operand

MSVC++ 2015 (14.0) doesn’t mind, and I thought that testing that version
would be enough, but the Crashpad buildbots still run MSVC++ 2013
(12.0), which doesn’t like this construct.

https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x64_dbg/builds/265/steps/compile%20with%20ninja/logs/stdio

TBR=scottmg@chromium.org (holiday)

Change-Id: Ia8d140ceda3cd1bdec09c78560377b9bfad84dc4
Reviewed-on: https://chromium-review.googlesource.com/410128
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-11-11 17:54:08 +00:00

65 lines
1.5 KiB
C++

// Copyright 2016 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "util/misc/arraysize_unsafe.h"
#include "gtest/gtest.h"
namespace crashpad {
namespace test {
namespace {
TEST(ArraySizeUnsafe, ArraySizeUnsafe) {
char c1[1];
static_assert(ARRAYSIZE_UNSAFE(c1) == 1, "c1");
char c2[2];
static_assert(ARRAYSIZE_UNSAFE(c2) == 2, "c2");
char c4[4];
static_assert(ARRAYSIZE_UNSAFE(c4) == 4, "c4");
int i1[1];
static_assert(ARRAYSIZE_UNSAFE(i1) == 1, "i1");
int i2[2];
static_assert(ARRAYSIZE_UNSAFE(i2) == 2, "i2");
int i4[4];
static_assert(ARRAYSIZE_UNSAFE(i4) == 4, "i4");
long l8[8];
static_assert(ARRAYSIZE_UNSAFE(l8) == 8, "l8");
int l9[9];
static_assert(ARRAYSIZE_UNSAFE(l9) == 9, "l9");
struct S {
char c;
int i;
long l;
bool b;
};
S s1[1];
static_assert(ARRAYSIZE_UNSAFE(s1) == 1, "s1");
S s10[10];
static_assert(ARRAYSIZE_UNSAFE(s10) == 10, "s10");
}
} // namespace
} // namespace test
} // namespace crashpad