mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
c009b85449
Since gtest 00938b2b228f, gtest has built-in first-class support for skipping tests, which is functionally identical (at least in Crashpad’s usage) to the home-grown support for run-time dynamically disabled tests introduced in Crashpad 5e9ed4cb9f69. Use the new standard pattern, and remove all vestiges of the custom local one. This was done previously in 79f4a3970a64, but was reverted in bba9d0819c12 because Chromium’s test launcher did not support GTEST_SKIP() at the time. The deficiency is on file as https://crbug.com/912138. While that bug was never specifically marked as “fixed” and I haven’t found what changed in Chromium, I do now see some use of GTEST_SKIP() in Chromium. I also prototyped this change in Chromium at https://chromium-review.googlesource.com/c/1854691/ and found that GTEST_SKIP() does indeed now appear to work. Change-Id: I13fef8fe8bfd9854a40dfa5910a3282d1a85bc45 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1855380 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>