mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
6978bf7646
This replaces the registration server, and adds dispatch to a delegate on crash requests. (As you are already aware) we went around in circles on trying to come up with a slightly-too-fancy threading design. All of them seemed to have problems when it comes to out of order events, and orderly shutdown, so I've gone back to something not-too-fancy. Two named pipe instances (that clients connect to) are created. These are used only for registration (which should take <1ms), so 2 should be sufficient to avoid any waits. When a client registers, we duplicate an event to it, which is used to signal when it wants a dump taken. The server registers threadpool waits on that event, and also on the process handle (which will be signalled when the client process exits). These requests (in particular the taking of the dump) are serviced on the threadpool, which avoids us needing to manage those threads, but still allows parallelism in taking dumps. On process termination, we use an IO Completion Port to post a message back to the main thread to request cleanup. This complexity is necessary so that we can unregister the threadpool waits without being on the threadpool, which we need to do synchronously so that we can be sure that no further callbacks will execute (and expect to have the client data around still). In a followup, I will readd support for DumpWithoutCrashing -- I don't think it will be too difficult now that we have an orderly way to clean up client records in the server. R=cpu@chromium.org, mark@chromium.org, jschuh@chromium.org BUG=crashpad:1,crashpad:45 Review URL: https://codereview.chromium.org/1301853002 .
43 lines
1.2 KiB
Python
43 lines
1.2 KiB
Python
# Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
{
|
|
'targets': [
|
|
{
|
|
'target_name': 'All',
|
|
'type': 'none',
|
|
'suppress_wildcard': 1,
|
|
'dependencies': [
|
|
'client/client.gyp:*',
|
|
'client/client_test.gyp:*',
|
|
'compat/compat.gyp:*',
|
|
'handler/handler.gyp:*',
|
|
'minidump/minidump.gyp:*',
|
|
'minidump/minidump_test.gyp:*',
|
|
'snapshot/snapshot.gyp:*',
|
|
'snapshot/snapshot_test.gyp:*',
|
|
'test/test.gyp:*',
|
|
'test/test_test.gyp:*',
|
|
'tools/tools.gyp:*',
|
|
'util/util.gyp:*',
|
|
'util/util_test.gyp:*',
|
|
],
|
|
'sources': [
|
|
'doc/support/crashpad.doxy.h',
|
|
'package.h',
|
|
],
|
|
},
|
|
],
|
|
}
|