mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-09 22:26:06 +00:00
6823f67830
Although GCC will silently accept larger alignments with __attribute__((aligned())), it warn on alignas() with an alignment larger than the target’s supported maximum. 8c35d92ae403 switched to alignas() where possible. The maxima are at least 128 on x86, x86_64, and arm64, and 64 on arm, in the common configurations, but may be even larger with certain features such as AVX enabled. These are ultimately derived from BIGGEST_ALIGNMENT in gcc/config/*/*.h. One alignment request in a test specified 1024 as a big alignment constraint, solely as a test that alignment worked correctly. For this, it’s perfectly reasonable to limit the alignment request to what GCC supports on the most constrained target we’ll encounter. Test: crashapd_util_test AlignedAllocator.AlignedVector Change-Id: I42af443f437e01228934ab34dc04983742f0ab3f Reviewed-on: https://chromium-review.googlesource.com/550236 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>