mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-14 01:08:01 +08:00
6798ba912e
In preference to (the reverted) https://chromium-review.googlesource.com/c/crashpad/crashpad/+/923178 this does not share implementation with the tests in snapshot/crashpad_info_client_options_test.cc. This is not done because those tests use faked CrashpadInfo structures that are intentionally differently sized than the current defintion of CrashpadInfo, meaning that the scoped reset could overwrite past the end of the structure. Not resetting these was causing CrashpadInfoClientOptions tests to fail on Fuchsia, because dlclose() [legally] doesn't do anything, so modifying the current binaries CrashpadInfo caused the expected values from child .sos to be ignored. That could be worked around in that test too, but it's probably better to clean up the global state in this test anyway. Bug: crashpad:196 Change-Id: Ia3f81f1d5872b5ef7d543fcc68b56af4c0b6ca0a Reviewed-on: https://chromium-review.googlesource.com/923561 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>