mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-15 01:50:34 +08:00
4539fd1553
between classic and extension structures.
Previosly, each MinidumpModuleCrashpadInfo structure contained a
minidump_module_list_index field referencing a module in the
MINIDUMP_MODULE_LIST stream by index. This layout was discovered to
cause a problem for the new minidump reader in ModuleSnapshotMinidump.
Instead, the module list index for linkage should be contained in the
MinidumpModuleCrashpadInfoList alongside the LOCATION_DESCRIPTORs
pointing to each MinidumpModuleCrashpadInfo.
The organizational difference is small, but this enables a better design
for ModuleSnapshotMinidump. When initializing a ModuleSnapshotMinidump
with the new layout, it is possible for the caller to have access to the
location descriptor for the MinidumpModuleCrashpadInfo corresponding to
a MINIDUMP_MODULE_LIST. Previously, the caller would not have had this
data without interpreting each MinidumpModuleCrashpadInfo, which
ModuleSnapshotMinidump would have to do anyway.
MinidumpModuleCrashpadInfoListWriter was the only user of
MinidumpLocationDescriptorListWriter, which is obsoleted and removed in
this change. Its functionality is moving directly into
MinidumpModuleCrashpadInfoListWriter, but it is no longer generic enough
to maintain as a distinct class.
TEST=minidump_test \
MinidumpModuleCrashpadInfoWriter.*,MinidumpCrashpadInfoWriter.*
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/978463003
117 lines
4.1 KiB
Python
117 lines
4.1 KiB
Python
# Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
{
|
|
'targets': [
|
|
{
|
|
'target_name': 'minidump',
|
|
'type': 'static_library',
|
|
'dependencies': [
|
|
'../compat/compat.gyp:compat',
|
|
'../snapshot/snapshot.gyp:snapshot',
|
|
'../third_party/mini_chromium/mini_chromium/base/base.gyp:base',
|
|
'../util/util.gyp:util',
|
|
],
|
|
'export_dependent_settings': [
|
|
'../compat/compat.gyp:compat',
|
|
],
|
|
'include_dirs': [
|
|
'..',
|
|
],
|
|
'sources': [
|
|
'minidump_context.h',
|
|
'minidump_context_writer.cc',
|
|
'minidump_context_writer.h',
|
|
'minidump_crashpad_info_writer.cc',
|
|
'minidump_crashpad_info_writer.h',
|
|
'minidump_exception_writer.cc',
|
|
'minidump_exception_writer.h',
|
|
'minidump_extensions.cc',
|
|
'minidump_extensions.h',
|
|
'minidump_file_writer.cc',
|
|
'minidump_file_writer.h',
|
|
'minidump_memory_writer.cc',
|
|
'minidump_memory_writer.h',
|
|
'minidump_misc_info_writer.cc',
|
|
'minidump_misc_info_writer.h',
|
|
'minidump_module_crashpad_info_writer.cc',
|
|
'minidump_module_crashpad_info_writer.h',
|
|
'minidump_module_writer.cc',
|
|
'minidump_module_writer.h',
|
|
'minidump_rva_list_writer.cc',
|
|
'minidump_rva_list_writer.h',
|
|
'minidump_simple_string_dictionary_writer.cc',
|
|
'minidump_simple_string_dictionary_writer.h',
|
|
'minidump_stream_writer.cc',
|
|
'minidump_stream_writer.h',
|
|
'minidump_string_writer.cc',
|
|
'minidump_string_writer.h',
|
|
'minidump_system_info_writer.cc',
|
|
'minidump_system_info_writer.h',
|
|
'minidump_thread_id_map.cc',
|
|
'minidump_thread_id_map.h',
|
|
'minidump_thread_writer.cc',
|
|
'minidump_thread_writer.h',
|
|
'minidump_writable.cc',
|
|
'minidump_writable.h',
|
|
'minidump_writer_util.cc',
|
|
'minidump_writer_util.h',
|
|
],
|
|
},
|
|
{
|
|
'target_name': 'minidump_test',
|
|
'type': 'executable',
|
|
'dependencies': [
|
|
'minidump',
|
|
'../snapshot/snapshot.gyp:snapshot_test_lib',
|
|
'../third_party/gtest/gtest.gyp:gtest',
|
|
'../third_party/gtest/gtest.gyp:gtest_main',
|
|
'../third_party/mini_chromium/mini_chromium/base/base.gyp:base',
|
|
],
|
|
'include_dirs': [
|
|
'..',
|
|
],
|
|
'sources': [
|
|
'minidump_context_writer_test.cc',
|
|
'minidump_crashpad_info_writer_test.cc',
|
|
'minidump_exception_writer_test.cc',
|
|
'minidump_file_writer_test.cc',
|
|
'minidump_memory_writer_test.cc',
|
|
'minidump_misc_info_writer_test.cc',
|
|
'minidump_module_crashpad_info_writer_test.cc',
|
|
'minidump_module_writer_test.cc',
|
|
'minidump_rva_list_writer_test.cc',
|
|
'minidump_simple_string_dictionary_writer_test.cc',
|
|
'minidump_string_writer_test.cc',
|
|
'minidump_system_info_writer_test.cc',
|
|
'minidump_thread_id_map_test.cc',
|
|
'minidump_thread_writer_test.cc',
|
|
'minidump_writable_test.cc',
|
|
'test/minidump_context_test_util.cc',
|
|
'test/minidump_context_test_util.h',
|
|
'test/minidump_file_writer_test_util.cc',
|
|
'test/minidump_file_writer_test_util.h',
|
|
'test/minidump_memory_writer_test_util.cc',
|
|
'test/minidump_memory_writer_test_util.h',
|
|
'test/minidump_rva_list_test_util.cc',
|
|
'test/minidump_rva_list_test_util.h',
|
|
'test/minidump_string_writer_test_util.cc',
|
|
'test/minidump_string_writer_test_util.h',
|
|
'test/minidump_writable_test_util.cc',
|
|
'test/minidump_writable_test_util.h',
|
|
],
|
|
},
|
|
],
|
|
}
|