mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 16:45:53 +08:00
Mark Mentovai
5e8e72f91c
Don’t use DYLD_INSERT_LIBRARIES with a system executable.
OS X 10.11 introduces System Integrity Protection. One facet of that forbids code injection into system executables. A Crashpad test checks that information can be recovered from dyld in early-launch crashes by requesting dyld load a nonexistent library with DYLD_INSERT_LIBRARIES. The executable was meaningless but a system-provided executable, /usr/bin/true, was used for convenience. This test hung on OS X 10.11 because DYLD_INSERT_LIBRARIES was ignored for the system executable, and no crash occurred. The test waited for a crash that would never come. A custom no-op executable, crashpad_snapshot_test_no_op, is provided as an executable that does work with DYLD_INSERT_LIBRARIES. BUG=crashpad:41 TEST=crashpad_snapshot_test MachOImageAnnotationsReader.CrashDyld R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1276553005 .
Description
Languages
C++
92.6%
Objective-C++
2.5%
C
2%
Python
1.7%
Assembly
0.9%
Other
0.3%