mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
c6adcc2482
CrashpadClient::DumpAndCrashTargetProcess() suspends the target process and injects a thread to raise an exception. The injected thread is not suspended, and may proceed to the point that the system recognizes the process as terminating by the time the overall process suspension is lifted. Previously, if this happened, an extraneous error was logged for the attempt to resume a terminating process. This introduces “termination tolerance” to ScopedProcessSuspend, which allows an object to be configured to ignore this error and not log any messages when this condition is expected. This resolves log messages such as this one, produced frequently during calls to CrashpadClient::DumpAndCrashTargetProcess() (including in end_to_end_test.py): > [pid:tid:yyyymmdd,hhmmss.mmm:ERROR scoped_process_suspend.cc:39] > NtResumeProcess: An attempt was made to access an exiting process. > (0xc000010a) 0xc000010a = STATUS_PROCESS_IS_TERMINATING Test: end_to_end_test.py Change-Id: Iab4c50fb21adce5502080ad25a6f734ec566d65c Reviewed-on: https://chromium-review.googlesource.com/700715 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
50 lines
1.4 KiB
C++
50 lines
1.4 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/win/scoped_process_suspend.h"
|
|
|
|
#include <stddef.h>
|
|
#include <winternl.h>
|
|
|
|
#include "util/win/nt_internals.h"
|
|
#include "util/win/ntstatus_logging.h"
|
|
|
|
namespace crashpad {
|
|
|
|
ScopedProcessSuspend::ScopedProcessSuspend(HANDLE process) {
|
|
NTSTATUS status = NtSuspendProcess(process);
|
|
if (NT_SUCCESS(status)) {
|
|
process_ = process;
|
|
} else {
|
|
process_ = nullptr;
|
|
NTSTATUS_LOG(ERROR, status) << "NtSuspendProcess";
|
|
}
|
|
}
|
|
|
|
ScopedProcessSuspend::~ScopedProcessSuspend() {
|
|
if (process_) {
|
|
NTSTATUS status = NtResumeProcess(process_);
|
|
if (!NT_SUCCESS(status) &&
|
|
(!tolerate_termination_ || status != STATUS_PROCESS_IS_TERMINATING)) {
|
|
NTSTATUS_LOG(ERROR, status) << "NtResumeProcess";
|
|
}
|
|
}
|
|
}
|
|
|
|
void ScopedProcessSuspend::TolerateTermination() {
|
|
tolerate_termination_ = true;
|
|
}
|
|
|
|
} // namespace crashpad
|