mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
6d5bd1d04d
This reverts 55133d332b6c and adds a broken dummy SafeTerminateProcess()
for cross builds instead. It’s similar to 2f4516f93838, which was for
CaptureContext().
This upstreams
af5f31ed61
(slightly modified).
The dummy implementation in the “broken” file affords no protection
against third-party code patching TerminateProcess() badly. The “broken”
file is not used by Crashpad anywhere at all, and is only used by
Crashpad in Chromium during a cross build targeting Windows without the
benefit of Microsoft’s ml.exe assembler. Strictly speaking, this file
does not need to be checked in to the Crashpad repository, but since
Chromium needs it to unblock its not-production-ready cross build for
Windows, it’s being landed here to avoid Chromium’s copy of Crashpad
appearing as modified or “dirty” relative to this upstream copy.
Bug: chromium:762167, chromium:777924
Change-Id: Iba68c0cab142fbe9541ea254a9a856b8263e4c70
Reviewed-on: https://chromium-review.googlesource.com/735078
Reviewed-by: Mark Mentovai <mark@chromium.org>
35 lines
1.2 KiB
C++
35 lines
1.2 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/win/safe_terminate_process.h"
|
|
|
|
#include "base/logging.h"
|
|
|
|
#if defined(ARCH_CPU_X86)
|
|
|
|
namespace crashpad {
|
|
|
|
bool SafeTerminateProcess(HANDLE process, UINT exit_code) {
|
|
// Third-party software that hooks TerminateProcess() incorrectly has been
|
|
// encountered in the wild. This version of SafeTerminateProcess() lacks
|
|
// protection against that, so don't use it in production.
|
|
LOG(WARNING)
|
|
<< "Don't use this! For cross builds only. See https://crbug.com/777924.";
|
|
return TerminateProcess(process, exit_code) != FALSE;
|
|
}
|
|
|
|
} // namespace crashpad
|
|
|
|
#endif // defined(ARCH_CPU_X86)
|