mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
5be8ce4ea0
Don't call GetFileVersionInfo(), which calls LoadLibrary() to be able to access the module's resources. Loading modules from the crashy process into the handler process can cause trouble. The Crashpad handler definitely doesn't want to run arbitrary modules' module initializer code. Since the VS_FIXEDFILEINFO needed is already in memory in the remote process' address space, just access it from there. BUG=crashpad:78 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1475023004 .
46 lines
1.7 KiB
C++
46 lines
1.7 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#ifndef CRASHPAD_UTIL_WIN_MODULE_VERSION_H_
|
||
#define CRASHPAD_UTIL_WIN_MODULE_VERSION_H_
|
||
|
||
#include <windows.h>
|
||
|
||
#include "base/files/file_path.h"
|
||
|
||
namespace crashpad {
|
||
|
||
//! \brief Retrieve the type and version information from a given module (exe,
|
||
//! dll, etc.)
|
||
//!
|
||
//! This function calls `GetFileVersionInfo()`, which can implicitly call
|
||
//! `LoadLibrary()` to load \a path into the calling process. Do not call this
|
||
//! function on an untrusted module, because there is a risk of executing the
|
||
//! module’s code.
|
||
//!
|
||
//! \param[in] path The path to the module to be inspected.
|
||
//! \param[out] vs_fixedfileinfo The VS_FIXEDFILEINFO on success.
|
||
//! VS_FIXEDFILEINFO::dwFileFlags will have been masked with
|
||
//! VS_FIXEDFILEINFO::dwFileFlagsMask already.
|
||
//!
|
||
//! \return `true` on success, or `false` on failure with a message logged. If
|
||
//! the module has no `VERSIONINFO` resource, `false` will be returned
|
||
//! without any messages logged.
|
||
bool GetModuleVersionAndType(const base::FilePath& path,
|
||
VS_FIXEDFILEINFO* vs_fixedfileinfo);
|
||
|
||
} // namespace crashpad
|
||
|
||
#endif // CRASHPAD_UTIL_WIN_MODULE_VERSION_H_
|