mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00

Go to file

Mark Mentovai 5b14b41992 GCC fix: Don’t name a method exactly the same as its return type

While compiling, for example,
minidump_simple_string_dictionary_writer.cc:

In file included from
../../minidump/minidump_module_crashpad_info_writer.cc:21:0:
../../minidump/minidump_simple_string_dictionary_writer.h:55:45: error:
declaration of ‘const crashpad::MinidumpSimpleStringDictionaryEntry*
crashpad::MinidumpSimpleStringDictionaryEntryWriter::MinidumpSimpleStringDictionaryEntry()
const’ [-fpermissive]
       MinidumpSimpleStringDictionaryEntry() const;
                                             ^~~~~
In file included from
../../minidump/minidump_module_crashpad_info_writer.h:25:0,
                 from
../../minidump/minidump_module_crashpad_info_writer.cc:15:
../../minidump/minidump_extensions.h:255:26: error: changes meaning of
‘MinidumpSimpleStringDictionaryEntry’ from ‘struct
crashpad::MinidumpSimpleStringDictionaryEntry’ [-fpermissive]
 struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionaryEntry {
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Tested with:
 - GCC 4.9 from NDK r13 targeting arm with SDK 16
 - GCC 4.9 from NDK r13 targeting arm64 with SDK 21
 - GCC 6.2 targeting x86_64

BUG=crashpad:30

Change-Id: I1e5e6a21a24f19eef7602e4123459ce15f3b089e
Reviewed-on: https://chromium-review.googlesource.com/409624
Reviewed-by: Robert Sesek <rsesek@chromium.org>

2016-11-11 17:36:17 +00:00

build

GCC fix: Disable -Wmultichar warning throughout Crashpad

2016-11-11 17:35:25 +00:00

client

doc: Fix all Doxygen warnings, cleaning up some generated documentation

2016-11-08 19:24:05 +00:00

compat

Provide backup #defines for things introduced in SDK 10.0.10240.0

2016-11-10 01:50:17 +00:00

doc

GCC fix: Disable -Wmultichar warning throughout Crashpad