mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 16:45:53 +08:00
57b2210ed7
This eliminates all constructors, but nearly all points of use were
using the default constructor to initialize a UUID member variable as in
uuid_(). This syntax will still produce a zeroed-out UUID.
While compiling, for example, minidump_rva_list_writer.cc:
In file included from ../../minidump/minidump_rva_list_writer.h:25:0,
from ../../minidump/minidump_rva_list_writer.cc:15:
../../minidump/minidump_extensions.h:412:8: error: ignoring packed attribute because of unpacked non-POD field ‘crashpad::UUID crashpad::MinidumpCrashpadInfo::report_id’ [-Werror]
UUID report_id;
^~~~~~~~~
../../minidump/minidump_extensions.h:424:8: error: ignoring packed attribute because of unpacked non-POD field ‘crashpad::UUID crashpad::MinidumpCrashpadInfo::client_id’ [-Werror]
UUID client_id;
^~~~~~~~~
Tested with:
- GCC 4.9 from NDK r13 targeting arm with SDK 16
- GCC 4.9 from NDK r13 targeting arm64 with SDK 21
- GCC 6.2 targeting x86_64
BUG=crashpad:30
Change-Id: Iec6b1557441b69d75246f2f75c59c4158fb7ca29
Reviewed-on: https://chromium-review.googlesource.com/409641
Reviewed-by: Scott Graham <scottmg@chromium.org>
102 lines
3.2 KiB
C++
102 lines
3.2 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#ifndef CRASHPAD_UTIL_MISC_UUID_H_
|
||
#define CRASHPAD_UTIL_MISC_UUID_H_
|
||
|
||
#include <stdint.h>
|
||
|
||
#include <string>
|
||
|
||
#include "base/strings/string16.h"
|
||
#include "base/strings/string_piece.h"
|
||
#include "build/build_config.h"
|
||
|
||
#if defined(OS_WIN)
|
||
#include <rpc.h>
|
||
#endif
|
||
|
||
namespace crashpad {
|
||
|
||
//! \brief A universally unique identifier (%UUID).
|
||
//!
|
||
//! An alternate term for %UUID is “globally unique identifier” (GUID), used
|
||
//! primarily by Microsoft.
|
||
//!
|
||
//! A %UUID is a unique 128-bit number specified by RFC 4122.
|
||
//!
|
||
//! This is a POD structure.
|
||
struct UUID {
|
||
bool operator==(const UUID& that) const;
|
||
bool operator!=(const UUID& that) const { return !operator==(that); }
|
||
|
||
//! \brief Initializes the %UUID to zero.
|
||
void InitializeToZero();
|
||
|
||
//! \brief Initializes the %UUID from a sequence of bytes.
|
||
//!
|
||
//! \a bytes is taken as a %UUID laid out in big-endian format in memory. On
|
||
//! little-endian machines, appropriate byte-swapping will be performed to
|
||
//! initialize an object’s data members.
|
||
//!
|
||
//! \param[in] bytes A buffer of exactly 16 bytes that will be assigned to the
|
||
//! %UUID.
|
||
void InitializeFromBytes(const uint8_t* bytes);
|
||
|
||
//! \brief Initializes the %UUID from a RFC 4122 §3 formatted string.
|
||
//!
|
||
//! \param[in] string A string of the form
|
||
//! `"00112233-4455-6677-8899-aabbccddeeff"`.
|
||
//!
|
||
//! \return `true` if the string was formatted correctly and the object has
|
||
//! been initialized with the data. `false` if the string could not be
|
||
//! parsed, with the object state untouched.
|
||
bool InitializeFromString(const base::StringPiece& string);
|
||
|
||
//! \brief Initializes the %UUID using a standard system facility to generate
|
||
//! the value.
|
||
//!
|
||
//! \return `true` if the %UUID was initialized correctly, `false` otherwise
|
||
//! with a message logged.
|
||
bool InitializeWithNew();
|
||
|
||
#if defined(OS_WIN) || DOXYGEN
|
||
//! \brief Initializes the %UUID from a system `UUID` or `GUID` structure.
|
||
//!
|
||
//! \param[in] system_uuid A system `UUID` or `GUID` structure.
|
||
void InitializeFromSystemUUID(const ::UUID* system_uuid);
|
||
#endif // OS_WIN
|
||
|
||
//! \brief Formats the %UUID per RFC 4122 §3.
|
||
//!
|
||
//! \return A string of the form `"00112233-4455-6677-8899-aabbccddeeff"`.
|
||
std::string ToString() const;
|
||
|
||
#if defined(OS_WIN) || DOXYGEN
|
||
//! \brief The same as ToString, but returned as a string16.
|
||
base::string16 ToString16() const;
|
||
#endif // OS_WIN
|
||
|
||
// These fields are laid out according to RFC 4122 §4.1.2.
|
||
uint32_t data_1;
|
||
uint16_t data_2;
|
||
uint16_t data_3;
|
||
uint8_t data_4[2];
|
||
uint8_t data_5[6];
|
||
};
|
||
|
||
} // namespace crashpad
|
||
|
||
#endif // CRASHPAD_UTIL_MISC_UUID_H_
|