crashpad

mirror of https://github.com/chromium/crashpad.git synced 2025-01-01 19:05:20 +08:00

History

Joshua Peraza 51779ce639 linux: Make MemoryMap retry when duplicates are detected

When the /proc/pid/maps file is not read atomically and the target
process is actively mapping memory, entries can be read multiple times
or missed entirely. This change makes MemoryMap read the whole contents
of the maps file before attempting to parse it as well as check for
duplication/overlap errors, retrying on failure. This change also adds
ptrace attachements to unit tests to reflect actual intended usage.

Bug: crashpad:30
Change-Id: Ie8549548e25c47baa418ee7439d82743f84ff41e
Reviewed-on: https://chromium-review.googlesource.com/491950
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

2017-05-02 17:28:31 +00:00

file

Add LoggingReadEntireFile for reading a file into a string

2017-05-02 04:01:48 +00:00

linux

linux: Make MemoryMap retry when duplicates are detected

2017-05-02 17:28:31 +00:00

mac

test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}

2017-04-04 12:34:24 +00:00

mach

Use FromPointerCast<>() in many places where it makes sense