mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-26 23:01:05 +08:00
bfc0eb5709
handler_sock end of the socketpair is donated to the crashpad server process which owns it. The client should not keep it open. Otherwise if the crashpad server process crashes and the client is reading from client_sock, the client will hang forever because the other end is still open. This happens when: - /proc/sys/kernel/yama/ptrace_scope file is present. - crashpad is invoked with missing required fields, like --database. In this case, chrome hangs until timeout. Change-Id: I1776432d6d9fd44dc1c24e874a15fd6d2a376003 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3786896 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Ayush Ranjan <ayushranjan@google.com>