mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-08 05:06:32 +08:00
4b450c8137
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
77d6b17338
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
118 lines
3.8 KiB
C++
118 lines
3.8 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/stdlib/aligned_allocator.h"
|
||
|
||
#include <stdint.h>
|
||
|
||
#include "gtest/gtest.h"
|
||
|
||
#if defined(OS_WIN)
|
||
#include <crtdbg.h>
|
||
#endif
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
bool IsAligned(void* pointer, size_t alignment) {
|
||
uintptr_t address = reinterpret_cast<uintptr_t>(pointer);
|
||
return (address & (alignment - 1)) == 0;
|
||
}
|
||
|
||
TEST(AlignedAllocator, AlignedVector) {
|
||
// Test a structure with natural alignment.
|
||
struct NaturalAlignedStruct {
|
||
int i;
|
||
};
|
||
|
||
AlignedVector<NaturalAlignedStruct> natural_aligned_vector;
|
||
natural_aligned_vector.push_back(NaturalAlignedStruct());
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[0], ALIGNOF(NaturalAlignedStruct)));
|
||
|
||
natural_aligned_vector.resize(3);
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[0], ALIGNOF(NaturalAlignedStruct)));
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[1], ALIGNOF(NaturalAlignedStruct)));
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[2], ALIGNOF(NaturalAlignedStruct)));
|
||
|
||
// Test a structure that declares its own alignment.
|
||
struct ALIGNAS(32) AlignedStruct {
|
||
int i;
|
||
};
|
||
ASSERT_EQ(ALIGNOF(AlignedStruct), 32u);
|
||
|
||
AlignedVector<AlignedStruct> aligned_vector;
|
||
aligned_vector.push_back(AlignedStruct());
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[0], ALIGNOF(AlignedStruct)));
|
||
|
||
aligned_vector.resize(3);
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[0], ALIGNOF(AlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[1], ALIGNOF(AlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[2], ALIGNOF(AlignedStruct)));
|
||
|
||
// Try a custom alignment. Since the structure itself doesn’t specify an
|
||
// alignment constraint, only the base address will be aligned to the
|
||
// requested boundary.
|
||
AlignedVector<NaturalAlignedStruct, 64> custom_aligned_vector;
|
||
custom_aligned_vector.push_back(NaturalAlignedStruct());
|
||
EXPECT_TRUE(IsAligned(&custom_aligned_vector[0], 64));
|
||
|
||
// Try a structure with a pretty big alignment request.
|
||
struct ALIGNAS(1024) BigAlignedStruct {
|
||
int i;
|
||
};
|
||
ASSERT_EQ(ALIGNOF(BigAlignedStruct), 1024u);
|
||
|
||
AlignedVector<BigAlignedStruct> big_aligned_vector;
|
||
big_aligned_vector.push_back(BigAlignedStruct());
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[0], ALIGNOF(BigAlignedStruct)));
|
||
|
||
big_aligned_vector.resize(3);
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[0], ALIGNOF(BigAlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[1], ALIGNOF(BigAlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[2], ALIGNOF(BigAlignedStruct)));
|
||
}
|
||
|
||
void BadAlignmentTest() {
|
||
#if defined(OS_WIN)
|
||
// Suppress the assertion MessageBox() normally displayed by the CRT in debug
|
||
// mode.
|
||
int previous = _CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG);
|
||
|
||
// In release mode, _CrtSetReportMode() is #defined to ((int)0), so |previous|
|
||
// would appear unused.
|
||
ALLOW_UNUSED_LOCAL(previous);
|
||
#endif
|
||
|
||
// Alignment constraints must be powers of 2. 7 is not valid.
|
||
AlignedVector<int, 7> bad_aligned_vector;
|
||
bad_aligned_vector.push_back(0);
|
||
|
||
#if defined(OS_WIN)
|
||
_CrtSetReportMode(_CRT_ASSERT, previous);
|
||
#endif
|
||
}
|
||
|
||
TEST(AlignedAllocatorDeathTest, BadAlignment) {
|
||
ASSERT_DEATH(BadAlignmentTest(), "");
|
||
}
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|