crashpad

mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00

Go to file

Scott Graham 4a5d21528e DCHECK_LE for cr_ngroups vs arraysize(cr_groups)

This DCHECK fails for me locally as

[----------] 3 tests from ProcessInfo
[ RUN      ] ProcessInfo.Self
[70989:10546846:20141216,112509.948519:FATAL process_info_mac.cc:114] Check failed: static_cast<size_t>(ngroups) < (sizeof(ArraySizeHelper(kern_proc_info_.kp_eproc.e_ucred.cr_groups))) (16 vs. 16).
Abort trap: 6

It doesn't seem to happen on the waterfall, so maybe I'm building against
an incorrect header? I don't particularly understand the code, but assuming
it's normal 0-based array, perhaps it should be a DCHECK_LE in any case.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/813473002

2014-12-16 12:18:32 -08:00

build

Fix run_tests to always run from the crashpad directory.

2014-12-12 17:16:11 -05:00

client

win: Get client/crashpad_info.cc to compile

2014-12-16 10:22:41 -08:00

compat

Move string16 and char16 in to base::

2014-12-12 11:06:09 -08:00

minidump

Move string16 and char16 in to base::