mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
0a4ea0b52d
All minidump objects now own their all of their children, rather than having them maintain weak pointers and requiring callers to maintain ownership. The only weak object in the entire tree now is the “extra memory” added to a MinidumpMemoryListWriter by its AddExtraMemory() method. Extra memory aliases objects owned elsewhere in the tree, typically by a MinidumpThreadWriter as stack memory. Non-“extra” memory added to a MinidumpMemoryListWriter by its AddMemory() method is strongly owned. Many objects are now deleted through base pointers, and in those cases, the base classes now have public virtual destructors. The ultimate base, MinidumpWritable, is still protected to guard against direct instantiation and deletion, and thus its destructor does not need to be virtual. This updates mini_chromium to eeb3b6a4f020 specifically for that revision, which includes necessary updates to scoped_ptr. It also picks up: eeb3b6a4f020 Update base/move.h and base/memory/scoped_ptr.h to match 67ad2efafaba More porting to Windows be27a006421e AUTHORS: Fix link post-git migration flag day. 05f5b1503230 Add codereview.settings to mini_chromium. a32c2b199811 Beginnings of Windows support in mini_chromium TEST=minidump_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/674153002
50 lines
1.3 KiB
C++
50 lines
1.3 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "minidump/minidump_stream_writer.h"
|
|
|
|
#include "base/logging.h"
|
|
|
|
namespace crashpad {
|
|
namespace internal {
|
|
|
|
MinidumpStreamWriter::~MinidumpStreamWriter() {
|
|
}
|
|
|
|
const MINIDUMP_DIRECTORY* MinidumpStreamWriter::DirectoryListEntry() const {
|
|
DCHECK_EQ(state(), kStateWritable);
|
|
|
|
return &directory_list_entry_;
|
|
}
|
|
|
|
MinidumpStreamWriter::MinidumpStreamWriter()
|
|
: MinidumpWritable(), directory_list_entry_() {
|
|
}
|
|
|
|
bool MinidumpStreamWriter::Freeze() {
|
|
DCHECK_EQ(state(), kStateMutable);
|
|
|
|
if (!MinidumpWritable::Freeze()) {
|
|
return false;
|
|
}
|
|
|
|
directory_list_entry_.StreamType = StreamType();
|
|
RegisterLocationDescriptor(&directory_list_entry_.Location);
|
|
|
|
return true;
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace crashpad
|