mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-26 23:01:05 +08:00
3e065b11d0
CFI attempts to verify that the dynamic type of a function object matches the static type of the function pointer used to call it. https://clang.llvm.org/docs/ControlFlowIntegrity.html#indirect-function-call-checking However, the analyzer does not have enough information to check cross-dso calls. In these instances, CFI crashes upon calling the function with an error like: pthread_create_linux.cc:60:16: runtime error: control flow integrity check for type 'int (unsigned long *, const pthread_attr_t *, void *(*)(void *), void *)' failed during indirect function call (/lib/x86_64-linux-gnu/libpthread.so.0+0x9200): note: (unknown) defined here pthread_create_linux.cc:60:16: note: check failed in crashpad_handler, destination function located in /lib/x86_64-linux-gnu/libpthread.so.0 Change-Id: Ib29dabfe714f2ee9cc06a5d17e6899ff81a06df4 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2339332 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
72 lines
1.9 KiB
C++
72 lines
1.9 KiB
C++
// Copyright 2020 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <dlfcn.h>
|
|
#include <pthread.h>
|
|
|
|
#include "base/logging.h"
|
|
#include "client/crashpad_client.h"
|
|
#include "util/misc/no_cfi_icall.h"
|
|
|
|
namespace {
|
|
|
|
using StartRoutineType = void* (*)(void*);
|
|
|
|
struct StartParams {
|
|
StartRoutineType start_routine;
|
|
void* arg;
|
|
};
|
|
|
|
void* InitializeSignalStackAndStart(StartParams* params) {
|
|
crashpad::CrashpadClient::InitializeSignalStackForThread();
|
|
|
|
StartParams local_params = *params;
|
|
delete params;
|
|
|
|
return local_params.start_routine(local_params.arg);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
extern "C" {
|
|
|
|
__attribute__((visibility("default"))) int pthread_create(
|
|
pthread_t* thread,
|
|
const pthread_attr_t* attr,
|
|
StartRoutineType start_routine,
|
|
void* arg) {
|
|
static const crashpad::NoCfiIcall<decltype(pthread_create)*>
|
|
next_pthread_create([]() {
|
|
const auto next_pthread_create = dlsym(RTLD_NEXT, "pthread_create");
|
|
CHECK(next_pthread_create) << "dlsym: " << dlerror();
|
|
return next_pthread_create;
|
|
}());
|
|
|
|
StartParams* params = new StartParams;
|
|
params->start_routine = start_routine;
|
|
params->arg = arg;
|
|
|
|
int result = next_pthread_create(
|
|
thread,
|
|
attr,
|
|
reinterpret_cast<StartRoutineType>(InitializeSignalStackAndStart),
|
|
params);
|
|
if (result != 0) {
|
|
delete params;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
} // extern "C"
|