crashpad/test/multiprocess_exec_posix.cc
Mark Mentovai 4b450c8137 test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.

This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.

EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.

References:

https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
77d6b17338
https://github.com/google/googletest/pull/713

Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 12:34:24 +00:00

152 lines
4.9 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2014 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "test/multiprocess_exec.h"
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include "base/posix/eintr_wrapper.h"
#include "gtest/gtest.h"
#include "test/errors.h"
#include "util/misc/scoped_forbid_return.h"
#include "util/posix/close_multiple.h"
#if defined(OS_LINUX)
#include <stdio_ext.h>
#endif
namespace crashpad {
namespace test {
MultiprocessExec::MultiprocessExec()
: Multiprocess(),
command_(),
arguments_(),
argv_() {
}
void MultiprocessExec::SetChildCommand(
const std::string& command, const std::vector<std::string>* arguments) {
command_ = command;
if (arguments) {
arguments_ = *arguments;
} else {
arguments_.clear();
}
}
MultiprocessExec::~MultiprocessExec() {
}
void MultiprocessExec::PreFork() {
ASSERT_NO_FATAL_FAILURE(Multiprocess::PreFork());
ASSERT_FALSE(command_.empty());
// Build up the argv vector. This is done in PreFork() instead of
// MultiprocessChild() because although the result is only needed in the child
// process, building it is a hazardous operation in that process.
ASSERT_TRUE(argv_.empty());
argv_.push_back(command_.c_str());
for (const std::string& argument : arguments_) {
argv_.push_back(argument.c_str());
}
argv_.push_back(nullptr);
}
void MultiprocessExec::MultiprocessChild() {
// Make sure that stdin, stdout, and stderr are FDs 0, 1, and 2, respectively.
// All FDs above this will be closed.
static_assert(STDIN_FILENO == 0, "stdin must be fd 0");
static_assert(STDOUT_FILENO == 1, "stdout must be fd 1");
static_assert(STDERR_FILENO == 2, "stderr must be fd 2");
// Move the read pipe to stdin.
FileHandle read_handle = ReadPipeHandle();
ASSERT_NE(read_handle, STDIN_FILENO);
ASSERT_NE(read_handle, STDOUT_FILENO);
ASSERT_EQ(fileno(stdin), STDIN_FILENO);
int rv;
#if defined(OS_LINUX)
__fpurge(stdin);
#else
rv = fpurge(stdin);
ASSERT_EQ(rv, 0) << ErrnoMessage("fpurge");
#endif
rv = HANDLE_EINTR(dup2(read_handle, STDIN_FILENO));
ASSERT_EQ(rv, STDIN_FILENO) << ErrnoMessage("dup2");
// Move the write pipe to stdout.
FileHandle write_handle = WritePipeHandle();
ASSERT_NE(write_handle, STDIN_FILENO);
ASSERT_NE(write_handle, STDOUT_FILENO);
ASSERT_EQ(fileno(stdout), STDOUT_FILENO);
// Make a copy of the original stdout file descriptor so that in case theres
// an execv() failure, the original stdout can be restored so that gtest
// messages directed to stdout go to the right place. Mark it as
// close-on-exec, so that the child wont see it after a successful exec(),
// but it will still be available in this process after an unsuccessful
// exec().
int dup_orig_stdout_fd = dup(STDOUT_FILENO);
ASSERT_GE(dup_orig_stdout_fd, 0) << ErrnoMessage("dup");
rv = fcntl(dup_orig_stdout_fd, F_SETFD, FD_CLOEXEC);
ASSERT_NE(rv, -1) << ErrnoMessage("fcntl");
rv = HANDLE_EINTR(fflush(stdout));
ASSERT_EQ(rv, 0) << ErrnoMessage("fflush");
rv = HANDLE_EINTR(dup2(write_handle, STDOUT_FILENO));
ASSERT_EQ(rv, STDOUT_FILENO) << ErrnoMessage("dup2");
CloseMultipleNowOrOnExec(STDERR_FILENO + 1, dup_orig_stdout_fd);
// Start the new program, replacing this one. execv() has a weird declaration
// where its argv argument is declared as char* const*. In reality, the
// implementation behaves as if the argument were const char* const*, and this
// behavior is required by the standard. See
// http://pubs.opengroup.org/onlinepubs/9699919799/functions/exec.html
// (search for “constant”).
execv(argv_[0], const_cast<char* const*>(&argv_[0]));
// This should not normally be reached. Getting here means that execv()
// failed.
// Be sure not to return until FAIL() is reached.
ScopedForbidReturn forbid_return;
// Put the original stdout back. Close the copy of the write pipe FD thats
// currently on stdout first, so that in case the dup2() that restores the
// original stdout fails, stdout isnt left attached to the pipe when the
// FAIL() statement executes.
HANDLE_EINTR(fflush(stdout));
IGNORE_EINTR(close(STDOUT_FILENO));
HANDLE_EINTR(dup2(dup_orig_stdout_fd, STDOUT_FILENO));
IGNORE_EINTR(close(dup_orig_stdout_fd));
forbid_return.Disarm();
FAIL() << ErrnoMessage("execv") << ": " << argv_[0];
}
} // namespace test
} // namespace crashpad