mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
57b2210ed7
This eliminates all constructors, but nearly all points of use were
using the default constructor to initialize a UUID member variable as in
uuid_(). This syntax will still produce a zeroed-out UUID.
While compiling, for example, minidump_rva_list_writer.cc:
In file included from ../../minidump/minidump_rva_list_writer.h:25:0,
from ../../minidump/minidump_rva_list_writer.cc:15:
../../minidump/minidump_extensions.h:412:8: error: ignoring packed attribute because of unpacked non-POD field ‘crashpad::UUID crashpad::MinidumpCrashpadInfo::report_id’ [-Werror]
UUID report_id;
^~~~~~~~~
../../minidump/minidump_extensions.h:424:8: error: ignoring packed attribute because of unpacked non-POD field ‘crashpad::UUID crashpad::MinidumpCrashpadInfo::client_id’ [-Werror]
UUID client_id;
^~~~~~~~~
Tested with:
- GCC 4.9 from NDK r13 targeting arm with SDK 16
- GCC 4.9 from NDK r13 targeting arm64 with SDK 21
- GCC 6.2 targeting x86_64
BUG=crashpad:30
Change-Id: Iec6b1557441b69d75246f2f75c59c4158fb7ca29
Reviewed-on: https://chromium-review.googlesource.com/409641
Reviewed-by: Scott Graham <scottmg@chromium.org>
126 lines
4.2 KiB
C++
126 lines
4.2 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "snapshot/win/process_snapshot_win.h"
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "build/build_config.h"
|
|
#include "gtest/gtest.h"
|
|
#include "snapshot/win/module_snapshot_win.h"
|
|
#include "snapshot/win/pe_image_reader.h"
|
|
#include "snapshot/win/process_reader_win.h"
|
|
#include "test/paths.h"
|
|
#include "test/win/child_launcher.h"
|
|
#include "util/file/file_io.h"
|
|
#include "util/win/scoped_handle.h"
|
|
#include "util/win/scoped_process_suspend.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
void TestImageReaderChild(const base::string16& directory_modification) {
|
|
UUID done_uuid;
|
|
done_uuid.InitializeWithNew();
|
|
ScopedKernelHANDLE done(
|
|
CreateEvent(nullptr, true, false, done_uuid.ToString16().c_str()));
|
|
ASSERT_TRUE(done.get());
|
|
|
|
base::FilePath test_executable = Paths::Executable();
|
|
std::wstring child_test_executable =
|
|
test_executable.DirName()
|
|
.Append(directory_modification)
|
|
.Append(test_executable.BaseName().RemoveFinalExtension().value() +
|
|
L"_image_reader.exe")
|
|
.value();
|
|
ChildLauncher child(child_test_executable, done_uuid.ToString16());
|
|
child.Start();
|
|
|
|
char c;
|
|
ASSERT_TRUE(LoggingReadFile(child.stdout_read_handle(), &c, sizeof(c)));
|
|
ASSERT_EQ(' ', c);
|
|
|
|
ScopedProcessSuspend suspend(child.process_handle());
|
|
|
|
ProcessSnapshotWin process_snapshot;
|
|
ASSERT_TRUE(process_snapshot.Initialize(
|
|
child.process_handle(), ProcessSuspensionState::kSuspended, 0, 0));
|
|
|
|
ASSERT_GE(process_snapshot.Modules().size(), 2u);
|
|
|
|
UUID uuid;
|
|
DWORD age;
|
|
std::string pdbname;
|
|
const std::string suffix(".pdb");
|
|
|
|
// Check the main .exe to see that we can retrieve its sections.
|
|
auto module = reinterpret_cast<const internal::ModuleSnapshotWin*>(
|
|
process_snapshot.Modules()[0]);
|
|
ASSERT_TRUE(module->pe_image_reader().DebugDirectoryInformation(
|
|
&uuid, &age, &pdbname));
|
|
EXPECT_NE(std::string::npos,
|
|
pdbname.find("crashpad_snapshot_test_image_reader"));
|
|
EXPECT_EQ(
|
|
0,
|
|
pdbname.compare(pdbname.size() - suffix.size(), suffix.size(), suffix));
|
|
|
|
// Check the dll it loads too.
|
|
module = reinterpret_cast<const internal::ModuleSnapshotWin*>(
|
|
process_snapshot.Modules().back());
|
|
ASSERT_TRUE(module->pe_image_reader().DebugDirectoryInformation(
|
|
&uuid, &age, &pdbname));
|
|
EXPECT_NE(std::string::npos,
|
|
pdbname.find("crashpad_snapshot_test_image_reader_module"));
|
|
EXPECT_EQ(
|
|
0,
|
|
pdbname.compare(pdbname.size() - suffix.size(), suffix.size(), suffix));
|
|
|
|
// Sum the size of the extra memory in all the threads and confirm it's near
|
|
// the limit that the child process set in its CrashpadInfo.
|
|
EXPECT_GE(process_snapshot.Threads().size(), 100u);
|
|
|
|
size_t extra_memory_total = 0;
|
|
for (const auto* thread : process_snapshot.Threads()) {
|
|
for (const auto* extra_memory : thread->ExtraMemory()) {
|
|
extra_memory_total += extra_memory->Size();
|
|
}
|
|
}
|
|
|
|
// We confirm we gathered less than 1M of extra data. The cap is set to only
|
|
// 100K, but there are other "extra memory" regions that aren't included in
|
|
// the cap. (Completely uncapped it would be > 10M.)
|
|
EXPECT_LT(extra_memory_total, 1000000u);
|
|
|
|
// Tell the child it can terminate.
|
|
SetEvent(done.get());
|
|
}
|
|
|
|
TEST(ProcessSnapshotTest, CrashpadInfoChild) {
|
|
TestImageReaderChild(FILE_PATH_LITERAL("."));
|
|
}
|
|
|
|
#if defined(ARCH_CPU_64_BITS)
|
|
TEST(ProcessSnapshotTest, CrashpadInfoChildWOW64) {
|
|
#ifndef NDEBUG
|
|
TestImageReaderChild(FILE_PATH_LITERAL("..\\..\\out\\Debug"));
|
|
#else
|
|
TestImageReaderChild(FILE_PATH_LITERAL("..\\..\\out\\Release"));
|
|
#endif
|
|
}
|
|
#endif
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|