mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 07:48:14 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
106 lines
3.1 KiB
C++
106 lines
3.1 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "minidump/minidump_rva_list_writer.h"
|
|
|
|
#include <utility>
|
|
|
|
#include "base/format_macros.h"
|
|
#include "base/stl_util.h"
|
|
#include "base/strings/stringprintf.h"
|
|
#include "gtest/gtest.h"
|
|
#include "minidump/test/minidump_rva_list_test_util.h"
|
|
#include "minidump/test/minidump_writable_test_util.h"
|
|
#include "util/file/string_file.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
class TestMinidumpRVAListWriter final : public internal::MinidumpRVAListWriter {
|
|
public:
|
|
TestMinidumpRVAListWriter() : MinidumpRVAListWriter() {}
|
|
~TestMinidumpRVAListWriter() override {}
|
|
|
|
void AddChild(uint32_t value) {
|
|
auto child = std::make_unique<TestUInt32MinidumpWritable>(value);
|
|
MinidumpRVAListWriter::AddChild(std::move(child));
|
|
}
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(TestMinidumpRVAListWriter);
|
|
};
|
|
|
|
TEST(MinidumpRVAListWriter, Empty) {
|
|
TestMinidumpRVAListWriter list_writer;
|
|
|
|
StringFile string_file;
|
|
|
|
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
|
|
EXPECT_EQ(string_file.string().size(), sizeof(MinidumpRVAList));
|
|
|
|
const MinidumpRVAList* list = MinidumpRVAListAtStart(string_file.string(), 0);
|
|
ASSERT_TRUE(list);
|
|
}
|
|
|
|
TEST(MinidumpRVAListWriter, OneChild) {
|
|
TestMinidumpRVAListWriter list_writer;
|
|
|
|
constexpr uint32_t kValue = 0;
|
|
list_writer.AddChild(kValue);
|
|
|
|
StringFile string_file;
|
|
|
|
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
|
|
|
|
const MinidumpRVAList* list = MinidumpRVAListAtStart(string_file.string(), 1);
|
|
ASSERT_TRUE(list);
|
|
|
|
const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
|
|
string_file.string(), list->children[0]);
|
|
ASSERT_TRUE(child);
|
|
EXPECT_EQ(*child, kValue);
|
|
}
|
|
|
|
TEST(MinidumpRVAListWriter, ThreeChildren) {
|
|
TestMinidumpRVAListWriter list_writer;
|
|
|
|
static constexpr uint32_t kValues[] = {0x80000000, 0x55555555, 0x66006600};
|
|
|
|
list_writer.AddChild(kValues[0]);
|
|
list_writer.AddChild(kValues[1]);
|
|
list_writer.AddChild(kValues[2]);
|
|
|
|
StringFile string_file;
|
|
|
|
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
|
|
|
|
const MinidumpRVAList* list =
|
|
MinidumpRVAListAtStart(string_file.string(), base::size(kValues));
|
|
ASSERT_TRUE(list);
|
|
|
|
for (size_t index = 0; index < base::size(kValues); ++index) {
|
|
SCOPED_TRACE(base::StringPrintf("index %" PRIuS, index));
|
|
|
|
const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
|
|
string_file.string(), list->children[index]);
|
|
ASSERT_TRUE(child);
|
|
EXPECT_EQ(*child, kValues[index]);
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|