mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-15 01:57:58 +08:00
44de18ca37
This change removes several unaligned accesses, as well a null pointer offset and an out of bounds array access. Bug: fuchsia:46805 Change-Id: I0110d0b7faf672655d978894b868760eee7b2988 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2583025 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
83 lines
2.9 KiB
C++
83 lines
2.9 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "minidump/test/minidump_memory_writer_test_util.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
|
|
TestMinidumpMemoryWriter::TestMinidumpMemoryWriter(uint64_t base_address,
|
|
size_t size,
|
|
uint8_t value)
|
|
: SnapshotMinidumpMemoryWriter(&test_snapshot_) {
|
|
test_snapshot_.SetAddress(base_address);
|
|
test_snapshot_.SetSize(size);
|
|
test_snapshot_.SetValue(value);
|
|
}
|
|
|
|
TestMinidumpMemoryWriter::~TestMinidumpMemoryWriter() {
|
|
}
|
|
|
|
void TestMinidumpMemoryWriter::SetShouldFailRead(bool should_fail) {
|
|
test_snapshot_.SetShouldFailRead(should_fail);
|
|
}
|
|
|
|
void ExpectMinidumpMemoryDescriptor(
|
|
const MINIDUMP_MEMORY_DESCRIPTOR* expected,
|
|
const MINIDUMP_MEMORY_DESCRIPTOR* observed) {
|
|
MINIDUMP_MEMORY_DESCRIPTOR expected_descriptor;
|
|
MINIDUMP_MEMORY_DESCRIPTOR observed_descriptor;
|
|
|
|
memcpy(&expected_descriptor, expected, sizeof(expected_descriptor));
|
|
memcpy(&observed_descriptor, observed, sizeof(observed_descriptor));
|
|
|
|
EXPECT_EQ(observed_descriptor.StartOfMemoryRange,
|
|
expected_descriptor.StartOfMemoryRange);
|
|
EXPECT_EQ(observed_descriptor.Memory.DataSize,
|
|
expected_descriptor.Memory.DataSize);
|
|
if (expected_descriptor.Memory.Rva != 0) {
|
|
constexpr uint32_t kMemoryAlignment = 16;
|
|
EXPECT_EQ(observed_descriptor.Memory.Rva,
|
|
(expected_descriptor.Memory.Rva + kMemoryAlignment - 1) &
|
|
~(kMemoryAlignment - 1));
|
|
}
|
|
}
|
|
|
|
void ExpectMinidumpMemoryDescriptorAndContents(
|
|
const MINIDUMP_MEMORY_DESCRIPTOR* expected,
|
|
const MINIDUMP_MEMORY_DESCRIPTOR* observed,
|
|
const std::string& file_contents,
|
|
uint8_t value,
|
|
bool at_eof) {
|
|
ExpectMinidumpMemoryDescriptor(expected, observed);
|
|
|
|
if (at_eof) {
|
|
EXPECT_EQ(observed->Memory.Rva + observed->Memory.DataSize,
|
|
file_contents.size());
|
|
} else {
|
|
EXPECT_GE(file_contents.size(),
|
|
observed->Memory.Rva + observed->Memory.DataSize);
|
|
}
|
|
|
|
std::string expected_data(expected->Memory.DataSize, value);
|
|
std::string observed_data(&file_contents[observed->Memory.Rva],
|
|
observed->Memory.DataSize);
|
|
EXPECT_EQ(observed_data, expected_data);
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace crashpad
|