mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
c009b85449
Since gtest 00938b2b228f, gtest has built-in first-class support for skipping tests, which is functionally identical (at least in Crashpad’s usage) to the home-grown support for run-time dynamically disabled tests introduced in Crashpad 5e9ed4cb9f69. Use the new standard pattern, and remove all vestiges of the custom local one. This was done previously in 79f4a3970a64, but was reverted in bba9d0819c12 because Chromium’s test launcher did not support GTEST_SKIP() at the time. The deficiency is on file as https://crbug.com/912138. While that bug was never specifically marked as “fixed” and I haven’t found what changed in Chromium, I do now see some use of GTEST_SKIP() in Chromium. I also prototyped this change in Chromium at https://chromium-review.googlesource.com/c/1854691/ and found that GTEST_SKIP() does indeed now appear to work. Change-Id: I13fef8fe8bfd9854a40dfa5910a3282d1a85bc45 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1855380 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
94 lines
2.9 KiB
C++
94 lines
2.9 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "build/build_config.h"
|
||
#include "gtest/gtest.h"
|
||
#include "test/main_arguments.h"
|
||
#include "test/multiprocess_exec.h"
|
||
|
||
#if defined(CRASHPAD_TEST_LAUNCHER_GMOCK)
|
||
#include "gmock/gmock.h"
|
||
#endif // CRASHPAD_TEST_LAUNCHER_GMOCK
|
||
|
||
#if defined(OS_WIN)
|
||
#include "test/win/win_child_process.h"
|
||
#endif // OS_WIN
|
||
|
||
#if defined(CRASHPAD_IS_IN_CHROMIUM)
|
||
#include "base/bind.h"
|
||
#include "base/test/launcher/unit_test_launcher.h"
|
||
#include "base/test/test_suite.h"
|
||
#endif // CRASHPAD_IS_IN_CHROMIUM
|
||
|
||
namespace {
|
||
|
||
bool GetChildTestFunctionName(std::string* child_func_name) {
|
||
constexpr size_t arg_length =
|
||
sizeof(crashpad::test::internal::kChildTestFunction) - 1;
|
||
for (const auto& it : crashpad::test::GetMainArguments()) {
|
||
if (it.compare(
|
||
0, arg_length, crashpad::test::internal::kChildTestFunction) == 0) {
|
||
*child_func_name = it.substr(arg_length);
|
||
return true;
|
||
}
|
||
}
|
||
return false;
|
||
}
|
||
|
||
} // namespace
|
||
|
||
int main(int argc, char* argv[]) {
|
||
crashpad::test::InitializeMainArguments(argc, argv);
|
||
|
||
std::string child_func_name;
|
||
if (GetChildTestFunctionName(&child_func_name)) {
|
||
return crashpad::test::internal::CheckedInvokeMultiprocessChild(
|
||
child_func_name);
|
||
}
|
||
|
||
#if defined(CRASHPAD_IS_IN_CHROMIUM)
|
||
|
||
#if defined(OS_WIN)
|
||
// Chromium’s test launcher interferes with WinMultiprocess-based tests. Allow
|
||
// their child processes to be launched by the standard gtest-based test
|
||
// runner.
|
||
const bool use_chromium_test_launcher =
|
||
!crashpad::test::WinChildProcess::IsChildProcess();
|
||
#else // OS_WIN
|
||
constexpr bool use_chromium_test_launcher = true;
|
||
#endif // OS_WIN
|
||
|
||
if (use_chromium_test_launcher) {
|
||
// This supports --test-launcher-summary-output, which writes a JSON file
|
||
// containing test details needed by Swarming.
|
||
base::TestSuite test_suite(argc, argv);
|
||
return base::LaunchUnitTests(
|
||
argc,
|
||
argv,
|
||
base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));
|
||
}
|
||
|
||
#endif // CRASHPAD_IS_IN_CHROMIUM
|
||
|
||
#if defined(CRASHPAD_TEST_LAUNCHER_GMOCK)
|
||
testing::InitGoogleMock(&argc, argv);
|
||
#elif defined(CRASHPAD_TEST_LAUNCHER_GTEST)
|
||
testing::InitGoogleTest(&argc, argv);
|
||
#else // CRASHPAD_TEST_LAUNCHER_GMOCK
|
||
#error #define CRASHPAD_TEST_LAUNCHER_GTEST or CRASHPAD_TEST_LAUNCHER_GMOCK
|
||
#endif // CRASHPAD_TEST_LAUNCHER_GMOCK
|
||
|
||
return RUN_ALL_TESTS();
|
||
}
|