mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-16 12:12:47 +08:00
50ed179e9a
Use BUILDFLAG(IS_*) instead of defined(OS_*).
This was generated mostly mechnically by performing the following steps:
- sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
-e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
$(git grep -l 'OS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
$(git grep -l '#ifdef BUILDFLAG('
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- gsed -i -z -E -e \
's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- Spot checks to move #include "build/buildflag.h" to the correct parts
of files.
- sed -i '' -E -e \
's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
$(grep -L '^#include "build/build_config.h"$'
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
- Add “clang-format off” around tool usage messages.
- git cl format
- Update mini_chromium to 85ba51f98278 (intermediate step).
TESTING ONLY).
- for f in $(git grep -l '^#include "build/buildflag.h"$'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
cp /tmp/z "${f}"; done
- git cl format
- Update mini_chromium to 735143774c5f (intermediate step).
- Update mini_chromium to f41420eb45fa (as checked in).
- Update mini_chromium to 6e2f204b4ae1 (as checked in).
For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.
This includes an update of mini_chromium to 6e2f204b4ae1:
f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h
Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
89 lines
2.6 KiB
C++
89 lines
2.6 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_UTIL_FILE_DIRECTORY_READER_H_
|
|
#define CRASHPAD_UTIL_FILE_DIRECTORY_READER_H_
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "build/build_config.h"
|
|
|
|
#if BUILDFLAG(IS_POSIX)
|
|
#include "util/posix/scoped_dir.h"
|
|
#elif BUILDFLAG(IS_WIN)
|
|
#include <windows.h>
|
|
|
|
#include "util/win/scoped_handle.h"
|
|
#endif // BUILDFLAG(IS_POSIX)
|
|
|
|
namespace crashpad {
|
|
|
|
//! \brief Iterates over the file and directory names in a directory.
|
|
//!
|
|
//! The names enumerated are relative to the specified directory and do not
|
|
//! include ".", "..", or files and directories in subdirectories.
|
|
class DirectoryReader {
|
|
public:
|
|
//! \brief The result of a call to NextFile().
|
|
enum class Result {
|
|
//! \brief An error occurred and a message was logged.
|
|
kError = -1,
|
|
|
|
//! \brief A file was found.
|
|
kSuccess,
|
|
|
|
//! \brief No more files were found.
|
|
kNoMoreFiles,
|
|
};
|
|
|
|
DirectoryReader();
|
|
|
|
DirectoryReader(const DirectoryReader&) = delete;
|
|
DirectoryReader& operator=(const DirectoryReader&) = delete;
|
|
|
|
~DirectoryReader();
|
|
|
|
//! \brief Opens the directory specified by \a path for reading.
|
|
//!
|
|
//! \param[in] path The path to the directory to read.
|
|
//! \return `true` on success. `false` on failure with a message logged.
|
|
bool Open(const base::FilePath& path);
|
|
|
|
//! \brief Advances the reader to the next file in the directory.
|
|
//!
|
|
//! \param[out] filename The filename of the next file.
|
|
//! \return a #Result value. \a filename is only valid when Result::kSuccess
|
|
//! is returned. If Result::kError is returned, a message will be
|
|
//! logged.
|
|
Result NextFile(base::FilePath* filename);
|
|
|
|
#if BUILDFLAG(IS_POSIX) || DOXYGEN
|
|
//! \brief Returns the file descriptor associated with this reader, logging a
|
|
//! message and returning -1 on error.
|
|
int DirectoryFD();
|
|
#endif
|
|
|
|
private:
|
|
#if BUILDFLAG(IS_POSIX)
|
|
ScopedDIR dir_;
|
|
#elif BUILDFLAG(IS_WIN)
|
|
WIN32_FIND_DATA find_data_;
|
|
ScopedSearchHANDLE handle_;
|
|
bool first_entry_;
|
|
#endif // BUILDFLAG(IS_POSIX)
|
|
};
|
|
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_UTIL_FILE_DIRECTORY_READER_H_
|