crashpad/util/misc/clock_test.cc
Mark Mentovai 48b1964d1b Use implicit_cast<> instead of static_cast<> whenever possible.
implicit_cast<> only performs a cast in cases where an implicit
conversion would be possible. It’s even safer than static_cast<> It’s an
“explicit implicit” cast, which is not normally necsesary, but is
frequently required when working with the ?: operator, functions like
std::min() and std::max(), and logging and testing macros.

The public style guide does not mention implicit_cast<> only because it
is not part of the standard library, but would otherwise require it in
these situations. Since base does provide implicit_cast<>, it should be
used whenever possible.

The only uses of static_cast<> not converted to implicit_cast<> are
those that require static_cast<>, such as those that assign an integer
constant to a variable of an enum type.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/700383007
2014-11-06 16:44:38 -05:00

93 lines
2.8 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2014 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "util/misc/clock.h"
#include <stdint.h>
#include <algorithm>
#include "base/basictypes.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
namespace crashpad {
namespace test {
namespace {
TEST(Clock, ClockMonotonicNanoseconds) {
uint64_t start = ClockMonotonicNanoseconds();
EXPECT_GT(start, 0u);
uint64_t now = start;
for (size_t iteration = 0; iteration < 10; ++iteration) {
uint64_t last = now;
now = ClockMonotonicNanoseconds();
// Use EXPECT_GE instead of EXPECT_GT, because there are no guarantees about
// the clocks resolution.
EXPECT_GE(now, last);
}
// SleepNanoseconds() should sleep for at least the value of the clocks
// resolution, so the clocks value should definitely increase after a sleep.
// EXPECT_GT can be used instead of EXPECT_GE after the sleep.
SleepNanoseconds(1);
now = ClockMonotonicNanoseconds();
EXPECT_GT(now, start);
}
void TestSleepNanoseconds(uint64_t nanoseconds) {
uint64_t start = ClockMonotonicNanoseconds();
SleepNanoseconds(nanoseconds);
uint64_t end = ClockMonotonicNanoseconds();
uint64_t diff = end - start;
// |nanoseconds| is the lower bound for the actual amount of time spent
// sleeping.
EXPECT_GE(diff, nanoseconds);
// Its difficult to set an upper bound for the time spent sleeping, and
// attempting to do so results in a flaky test.
}
TEST(Clock, SleepNanoseconds) {
const uint64_t kTestData[] = {
0,
1,
implicit_cast<uint64_t>(1E3), // 1 microsecond
implicit_cast<uint64_t>(1E4), // 10 microseconds
implicit_cast<uint64_t>(1E5), // 100 microseconds
implicit_cast<uint64_t>(1E6), // 1 millisecond
implicit_cast<uint64_t>(1E7), // 10 milliseconds
implicit_cast<uint64_t>(2E7), // 20 milliseconds
implicit_cast<uint64_t>(5E7), // 50 milliseconds
};
for (size_t index = 0; index < arraysize(kTestData); ++index) {
const uint64_t nanoseconds = kTestData[index];
SCOPED_TRACE(
base::StringPrintf("index %zu, nanoseconds %llu", index, nanoseconds));
TestSleepNanoseconds(nanoseconds);
}
}
} // namespace
} // namespace test
} // namespace crashpad