mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
52d766400d
There’s no reason for ProcessReader to own its ProcessMemoryLinux via
std::unique_ptr<>.
This was discovered in a trunk Clang build, during which a
-Wdelete-non-virtual-dtor warning was produced (since Clang r312167).
The warning is not produced by earlier Clang versions or by GCC because
the “delete” happens in a system header, <memory>, when performed by
std::unique_ptr<>. Although ownership via std::unique_ptr<> is no longer
used, ProcessMemoryLinux is marked “final” because it ought to be.
In file included from ../../snapshot/linux/process_reader.cc:15:
In file included from ../../snapshot/linux/process_reader.h:21:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/memory:80:
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/bits/unique_ptr.h:78:2: error: delete called on non-final 'crashpad::ProcessMemoryLinux' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
delete __ptr;
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/bits/unique_ptr.h:268:4: note: in instantiation of member function 'std::default_delete<crashpad::ProcessMemoryLinux>::operator()' requested here
get_deleter()(__ptr);
^
../../snapshot/linux/process_reader.cc:169:16: note: in instantiation of member function 'std::unique_ptr<crashpad::ProcessMemoryLinux, std::default_delete<crashpad::ProcessMemoryLinux> >::~unique_ptr' requested here
ProcessReader::ProcessReader()
^
1 error generated.
Change-Id: Ibe9671db429262aca12bbfdf457c8f72cad2f358
Reviewed-on: https://chromium-review.googlesource.com/738530
Reviewed-by: Dave Bort <dbort@google.com>
Commit-Queue: Mark Mentovai <mark@chromium.org>
63 lines
1.9 KiB
C++
63 lines
1.9 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_UTIL_PROCESS_PROCESS_MEMORY_LINUX_H_
|
|
#define CRASHPAD_UTIL_PROCESS_PROCESS_MEMORY_LINUX_H_
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <string>
|
|
|
|
#include "base/files/scoped_file.h"
|
|
#include "base/macros.h"
|
|
#include "util/misc/address_types.h"
|
|
#include "util/process/process_memory.h"
|
|
|
|
namespace crashpad {
|
|
|
|
//! \brief Accesses the memory of another Linux process.
|
|
class ProcessMemoryLinux final : public ProcessMemory {
|
|
public:
|
|
ProcessMemoryLinux();
|
|
~ProcessMemoryLinux();
|
|
|
|
//! \brief Initializes this object to read the memory of a process whose ID
|
|
//! is \a pid.
|
|
//!
|
|
//! This method must be called successfully prior to calling any other method
|
|
//! in this class.
|
|
//!
|
|
//! \param[in] pid The process ID of a target process.
|
|
//!
|
|
//! \return `true` on success, `false` on failure with a message logged.
|
|
bool Initialize(pid_t pid);
|
|
|
|
bool Read(VMAddress address, size_t size, void* buffer) const override;
|
|
|
|
private:
|
|
bool ReadCStringInternal(VMAddress address,
|
|
bool has_size,
|
|
size_t size,
|
|
std::string* string) const override;
|
|
|
|
base::ScopedFD mem_fd_;
|
|
pid_t pid_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(ProcessMemoryLinux);
|
|
};
|
|
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_UTIL_PROCESS_PROCESS_MEMORY_LINUX_H_
|