mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:32:35 +08:00
9168ba47ac
time_t is a typedef for long on Mac OS X. In 32-bit x86 (ILP32), long is a signed 32-bit quantity, and its range does not contain the range of uint32_t, used to store times in time_t fashion in minidump files. A cast is necessary to make these EXPECT_* macros do the right thing. This is not a problem in x86_64 (LP64) where long is a signed 64-bit quantity, which does contain the range of uint32_t. clang’s error was “error: comparison of integers of different signs: 'const long' and 'const unsigned int' [-Werror,-Wsign-compare]” BUG= R=rsesek@chromium.org Review URL: https://codereview.chromium.org/491023005