mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-26 23:01:05 +08:00
1aa478d161
This change was partially scripted and partially done manually with vim regex + manually placing the deleted constructors. The script change looked for destructors in the public: section of a class, if that existed the deleted constructors would go before the destructor. For manual placement I looked for any constructor in the public: section of the corresponding class. If there wasn't one, then it would ideally have gone as the first entry except below enums, classes and typedefs. This may not have been perfect, but is hopefully good enough. Fingers crossed. #include "base/macros.h" is removed from files that don't use ignore_result, which is the only other thing defined in base/macros.h. Bug: chromium:1010217 Change-Id: I099526255a40b1ac1264904b4ece2f3f503c9418 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3171034 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org>
108 lines
3.2 KiB
C++
108 lines
3.2 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "minidump/minidump_rva_list_writer.h"
|
|
|
|
#include <utility>
|
|
|
|
#include "base/cxx17_backports.h"
|
|
#include "base/format_macros.h"
|
|
#include "base/strings/stringprintf.h"
|
|
#include "gtest/gtest.h"
|
|
#include "minidump/test/minidump_rva_list_test_util.h"
|
|
#include "minidump/test/minidump_writable_test_util.h"
|
|
#include "util/file/string_file.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
class TestMinidumpRVAListWriter final : public internal::MinidumpRVAListWriter {
|
|
public:
|
|
TestMinidumpRVAListWriter() : MinidumpRVAListWriter() {}
|
|
|
|
TestMinidumpRVAListWriter(const TestMinidumpRVAListWriter&) = delete;
|
|
TestMinidumpRVAListWriter& operator=(const TestMinidumpRVAListWriter&) =
|
|
delete;
|
|
|
|
~TestMinidumpRVAListWriter() override {}
|
|
|
|
void AddChild(uint32_t value) {
|
|
auto child = std::make_unique<TestUInt32MinidumpWritable>(value);
|
|
MinidumpRVAListWriter::AddChild(std::move(child));
|
|
}
|
|
};
|
|
|
|
TEST(MinidumpRVAListWriter, Empty) {
|
|
TestMinidumpRVAListWriter list_writer;
|
|
|
|
StringFile string_file;
|
|
|
|
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
|
|
EXPECT_EQ(string_file.string().size(), sizeof(MinidumpRVAList));
|
|
|
|
const MinidumpRVAList* list = MinidumpRVAListAtStart(string_file.string(), 0);
|
|
ASSERT_TRUE(list);
|
|
}
|
|
|
|
TEST(MinidumpRVAListWriter, OneChild) {
|
|
TestMinidumpRVAListWriter list_writer;
|
|
|
|
constexpr uint32_t kValue = 0;
|
|
list_writer.AddChild(kValue);
|
|
|
|
StringFile string_file;
|
|
|
|
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
|
|
|
|
const MinidumpRVAList* list = MinidumpRVAListAtStart(string_file.string(), 1);
|
|
ASSERT_TRUE(list);
|
|
|
|
const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
|
|
string_file.string(), list->children[0]);
|
|
ASSERT_TRUE(child);
|
|
EXPECT_EQ(*child, kValue);
|
|
}
|
|
|
|
TEST(MinidumpRVAListWriter, ThreeChildren) {
|
|
TestMinidumpRVAListWriter list_writer;
|
|
|
|
static constexpr uint32_t kValues[] = {0x80000000, 0x55555555, 0x66006600};
|
|
|
|
list_writer.AddChild(kValues[0]);
|
|
list_writer.AddChild(kValues[1]);
|
|
list_writer.AddChild(kValues[2]);
|
|
|
|
StringFile string_file;
|
|
|
|
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
|
|
|
|
const MinidumpRVAList* list =
|
|
MinidumpRVAListAtStart(string_file.string(), base::size(kValues));
|
|
ASSERT_TRUE(list);
|
|
|
|
for (size_t index = 0; index < base::size(kValues); ++index) {
|
|
SCOPED_TRACE(base::StringPrintf("index %" PRIuS, index));
|
|
|
|
const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
|
|
string_file.string(), list->children[index]);
|
|
ASSERT_TRUE(child);
|
|
EXPECT_EQ(*child, kValues[index]);
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|