mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 07:48:14 +08:00
17d024e7df
This was broken by yours truly in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1057833/, probably because I couldn't decide whether to do it in HandleException() or HandleExceptionHandles() (or possibly I'm just a dope). In any case, suspending in HandleExceptionHandles() is fine, the thread for the exception will be suspended on entry, so suspending other threads after the initial excepting thread's koid to handle lookup is OK. This avoids a bunch of logspam like: zx_thread_read_state(ZX_THREAD_STATE_GENERAL_REGS): ZX_ERR_BAD_STATE (-20) and presumably will fix non-excepting-thread stacks being completely broken? Bug: fuchsia:DX-1190 Test: run `crasher write0_mt` on device Change-Id: I029537aba2955d4f055471bf36a4e9a0f8ef2d5e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1536268 Reviewed-by: Francois Rousseau <frousseau@google.com> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
Crashpad
Crashpad is a crash-reporting system.
Documentation
- Project status
- Developing Crashpad: instructions for getting the source code, building, testing, and contributing to the project.
- Crashpad interface documentation
- Crashpad tool man pages
- Crashpad overview design
Source Code
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.
Other Links
- Bugs can be reported at the Crashpad issue tracker.
- The Crashpad bots perform automated builds and tests.
- crashpad-dev is the Crashpad developers’ mailing list.