mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
50ed179e9a
Use BUILDFLAG(IS_*) instead of defined(OS_*).
This was generated mostly mechnically by performing the following steps:
- sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
-e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
$(git grep -l 'OS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
$(git grep -l '#ifdef BUILDFLAG('
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- gsed -i -z -E -e \
's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- Spot checks to move #include "build/buildflag.h" to the correct parts
of files.
- sed -i '' -E -e \
's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
$(grep -L '^#include "build/build_config.h"$'
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
- Add “clang-format off” around tool usage messages.
- git cl format
- Update mini_chromium to 85ba51f98278 (intermediate step).
TESTING ONLY).
- for f in $(git grep -l '^#include "build/buildflag.h"$'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
cp /tmp/z "${f}"; done
- git cl format
- Update mini_chromium to 735143774c5f (intermediate step).
- Update mini_chromium to f41420eb45fa (as checked in).
- Update mini_chromium to 6e2f204b4ae1 (as checked in).
For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.
This includes an update of mini_chromium to 6e2f204b4ae1:
f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h
Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
118 lines
3.9 KiB
C++
118 lines
3.9 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/stdlib/aligned_allocator.h"
|
||
|
||
#include <stdint.h>
|
||
|
||
#include "build/build_config.h"
|
||
#include "gtest/gtest.h"
|
||
#include "test/gtest_death.h"
|
||
|
||
#if BUILDFLAG(IS_WIN)
|
||
#include <crtdbg.h>
|
||
#endif
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
bool IsAligned(void* pointer, size_t alignment) {
|
||
uintptr_t address = reinterpret_cast<uintptr_t>(pointer);
|
||
return (address & (alignment - 1)) == 0;
|
||
}
|
||
|
||
TEST(AlignedAllocator, AlignedVector) {
|
||
// Test a structure with natural alignment.
|
||
struct NaturalAlignedStruct {
|
||
int i;
|
||
};
|
||
|
||
AlignedVector<NaturalAlignedStruct> natural_aligned_vector;
|
||
natural_aligned_vector.push_back(NaturalAlignedStruct());
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[0], alignof(NaturalAlignedStruct)));
|
||
|
||
natural_aligned_vector.resize(3);
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[0], alignof(NaturalAlignedStruct)));
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[1], alignof(NaturalAlignedStruct)));
|
||
EXPECT_TRUE(
|
||
IsAligned(&natural_aligned_vector[2], alignof(NaturalAlignedStruct)));
|
||
|
||
// Test a structure that declares its own alignment.
|
||
struct alignas(16) AlignedStruct {
|
||
int i;
|
||
};
|
||
ASSERT_EQ(alignof(AlignedStruct), 16u);
|
||
|
||
AlignedVector<AlignedStruct> aligned_vector;
|
||
aligned_vector.push_back(AlignedStruct());
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[0], alignof(AlignedStruct)));
|
||
|
||
aligned_vector.resize(3);
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[0], alignof(AlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[1], alignof(AlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&aligned_vector[2], alignof(AlignedStruct)));
|
||
|
||
// Try a custom alignment. Since the structure itself doesn’t specify an
|
||
// alignment constraint, only the base address will be aligned to the
|
||
// requested boundary.
|
||
AlignedVector<NaturalAlignedStruct, 32> custom_aligned_vector;
|
||
custom_aligned_vector.push_back(NaturalAlignedStruct());
|
||
EXPECT_TRUE(IsAligned(&custom_aligned_vector[0], 32));
|
||
|
||
// Try a structure with a pretty big alignment request.
|
||
struct alignas(64) BigAlignedStruct {
|
||
int i;
|
||
};
|
||
ASSERT_EQ(alignof(BigAlignedStruct), 64u);
|
||
|
||
AlignedVector<BigAlignedStruct> big_aligned_vector;
|
||
big_aligned_vector.push_back(BigAlignedStruct());
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[0], alignof(BigAlignedStruct)));
|
||
|
||
big_aligned_vector.resize(3);
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[0], alignof(BigAlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[1], alignof(BigAlignedStruct)));
|
||
EXPECT_TRUE(IsAligned(&big_aligned_vector[2], alignof(BigAlignedStruct)));
|
||
}
|
||
|
||
void BadAlignmentTest() {
|
||
#if BUILDFLAG(IS_WIN)
|
||
// Suppress the assertion MessageBox() normally displayed by the CRT in debug
|
||
// mode. In release mode, _CrtSetReportMode() is #defined to ((int)0), so
|
||
// |previous| would appear unused, thus the [[maybe_unused]].
|
||
[[maybe_unused]] int previous =
|
||
_CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG);
|
||
#endif
|
||
|
||
// Alignment constraints must be powers of 2. 7 is not valid.
|
||
AlignedVector<int, 7> bad_aligned_vector;
|
||
bad_aligned_vector.push_back(0);
|
||
|
||
#if BUILDFLAG(IS_WIN)
|
||
_CrtSetReportMode(_CRT_ASSERT, previous);
|
||
#endif
|
||
}
|
||
|
||
TEST(AlignedAllocatorDeathTest, BadAlignment) {
|
||
ASSERT_DEATH_CRASH(BadAlignmentTest(), "");
|
||
}
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|