mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:32:35 +08:00
1aa478d161
This change was partially scripted and partially done manually with vim regex + manually placing the deleted constructors. The script change looked for destructors in the public: section of a class, if that existed the deleted constructors would go before the destructor. For manual placement I looked for any constructor in the public: section of the corresponding class. If there wasn't one, then it would ideally have gone as the first entry except below enums, classes and typedefs. This may not have been perfect, but is hopefully good enough. Fingers crossed. #include "base/macros.h" is removed from files that don't use ignore_result, which is the only other thing defined in base/macros.h. Bug: chromium:1010217 Change-Id: I099526255a40b1ac1264904b4ece2f3f503c9418 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3171034 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org>
104 lines
2.8 KiB
C++
104 lines
2.8 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/thread/thread.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "util/synchronization/semaphore.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
class NoopThread : public Thread {
|
|
public:
|
|
NoopThread() {}
|
|
|
|
NoopThread(const NoopThread&) = delete;
|
|
NoopThread& operator=(const NoopThread&) = delete;
|
|
|
|
~NoopThread() override {}
|
|
|
|
private:
|
|
void ThreadMain() override {}
|
|
};
|
|
|
|
class WaitThread : public Thread {
|
|
public:
|
|
explicit WaitThread(Semaphore* semaphore) : semaphore_(semaphore) {}
|
|
|
|
WaitThread(const WaitThread&) = delete;
|
|
WaitThread& operator=(const WaitThread&) = delete;
|
|
|
|
~WaitThread() override {}
|
|
|
|
private:
|
|
void ThreadMain() override { semaphore_->Wait(); }
|
|
|
|
Semaphore* semaphore_;
|
|
};
|
|
|
|
class JoinAndSignalThread : public Thread {
|
|
public:
|
|
JoinAndSignalThread(Thread* thread, Semaphore* semaphore)
|
|
: thread_(thread), semaphore_(semaphore) {}
|
|
|
|
JoinAndSignalThread(const JoinAndSignalThread&) = delete;
|
|
JoinAndSignalThread& operator=(const JoinAndSignalThread&) = delete;
|
|
|
|
~JoinAndSignalThread() override {}
|
|
|
|
private:
|
|
void ThreadMain() override {
|
|
thread_->Join();
|
|
semaphore_->Signal();
|
|
}
|
|
|
|
Thread* thread_;
|
|
Semaphore* semaphore_;
|
|
};
|
|
|
|
TEST(ThreadTest, NoStart) {
|
|
NoopThread thread;
|
|
}
|
|
|
|
TEST(ThreadTest, Start) {
|
|
NoopThread thread;
|
|
thread.Start();
|
|
thread.Join();
|
|
}
|
|
|
|
TEST(ThreadTest, JoinBlocks) {
|
|
Semaphore unblock_wait_thread_semaphore(0);
|
|
Semaphore join_completed_semaphore(0);
|
|
WaitThread wait_thread(&unblock_wait_thread_semaphore);
|
|
wait_thread.Start();
|
|
JoinAndSignalThread join_and_signal_thread(&wait_thread,
|
|
&join_completed_semaphore);
|
|
join_and_signal_thread.Start();
|
|
// join_completed_semaphore will be signaled when wait_thread.Join() returns
|
|
// (in JoinAndSignalThread::ThreadMain). Since wait_thread is blocking on
|
|
// unblock_wait_thread_semaphore, we don't expect the Join to return yet. We
|
|
// wait up to 100ms to give a broken implementation of Thread::Join a chance
|
|
// to return.
|
|
ASSERT_FALSE(join_completed_semaphore.TimedWait(.1));
|
|
unblock_wait_thread_semaphore.Signal();
|
|
join_completed_semaphore.Wait();
|
|
join_and_signal_thread.Join();
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|