mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 15:50:26 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
82 lines
2.3 KiB
C++
82 lines
2.3 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "minidump/minidump_byte_array_writer.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "base/format_macros.h"
|
|
#include "base/stl_util.h"
|
|
#include "base/strings/stringprintf.h"
|
|
#include "gtest/gtest.h"
|
|
#include "minidump/test/minidump_writable_test_util.h"
|
|
#include "util/file/string_file.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
TEST(MinidumpByteArrayWriter, Write) {
|
|
const std::vector<uint8_t> kTests[] = {
|
|
{'h', 'e', 'l', 'l', 'o'},
|
|
{0x42, 0x99, 0x00, 0xbe},
|
|
{0x00},
|
|
{},
|
|
};
|
|
|
|
for (size_t i = 0; i < base::size(kTests); ++i) {
|
|
SCOPED_TRACE(base::StringPrintf("index %" PRIuS, i));
|
|
|
|
StringFile string_file;
|
|
|
|
crashpad::MinidumpByteArrayWriter writer;
|
|
writer.set_data(kTests[i]);
|
|
EXPECT_TRUE(writer.WriteEverything(&string_file));
|
|
|
|
ASSERT_EQ(string_file.string().size(),
|
|
sizeof(MinidumpByteArray) + kTests[i].size());
|
|
|
|
auto byte_array = std::make_unique<MinidumpByteArray>();
|
|
EXPECT_EQ(string_file.Seek(0, SEEK_SET), 0);
|
|
string_file.Read(byte_array.get(), sizeof(*byte_array));
|
|
|
|
EXPECT_EQ(byte_array->length, kTests[i].size());
|
|
|
|
std::vector<uint8_t> data(byte_array->length);
|
|
string_file.Read(data.data(), byte_array->length);
|
|
|
|
EXPECT_EQ(data, kTests[i]);
|
|
}
|
|
}
|
|
|
|
TEST(MinidumpByteArrayWriter, SetData) {
|
|
const std::vector<uint8_t> kTests[] = {
|
|
{1, 2, 3, 4, 5},
|
|
{0x0},
|
|
{},
|
|
};
|
|
|
|
for (size_t i = 0; i < base::size(kTests); ++i) {
|
|
SCOPED_TRACE(base::StringPrintf("index %" PRIuS, i));
|
|
|
|
crashpad::MinidumpByteArrayWriter writer;
|
|
writer.set_data(kTests[i].data(), kTests[i].size());
|
|
EXPECT_EQ(writer.data(), kTests[i]);
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|