crashpad/util/misc/initialization_state_test.cc
Daniel Cheng aef7de4e93 [MSan] "Fix" use-after-dtor in InitializationState.InitializationState
Since the test is specifically trying to exercise UB by testing the
state of an object it is already destroyed, unpoison the memory to
suppress MSan errors.

Bug: 40222690
Change-Id: I840e944f5e8b39668ac05d8d641fdd5f2e3db5ac
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5716150
Reviewed-by: Mark Mentovai <mark@chromium.org>
2024-07-17 17:08:24 +00:00

74 lines
2.6 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2014 The Crashpad Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "util/misc/initialization_state.h"
#include <stdlib.h>
#include <memory>
#include "base/compiler_specific.h"
#include "base/memory/free_deleter.h"
#include "gtest/gtest.h"
namespace crashpad {
namespace test {
namespace {
TEST(InitializationState, InitializationState) {
// Use placement new so that the buffer used to host the object remains live
// even after the object is destroyed.
std::unique_ptr<InitializationState, base::FreeDeleter>
initialization_state_buffer(
static_cast<InitializationState*>(malloc(sizeof(InitializationState))));
InitializationState* initialization_state =
new (initialization_state_buffer.get()) InitializationState();
EXPECT_TRUE(initialization_state->is_uninitialized());
EXPECT_FALSE(initialization_state->is_valid());
initialization_state->set_invalid();
EXPECT_FALSE(initialization_state->is_uninitialized());
EXPECT_FALSE(initialization_state->is_valid());
initialization_state->set_valid();
EXPECT_FALSE(initialization_state->is_uninitialized());
EXPECT_TRUE(initialization_state->is_valid());
initialization_state->~InitializationState();
// initialization_state points to something that no longer exists. This
// portion of the test is intended to check that after an InitializationState
// object is destroyed, it will not be considered valid on a use-after-free,
// assuming that nothing else was written to its former home in memory.
//
// Because initialization_state was constructed via placement new into a
// buffer thats still valid and its destructor was called directly, this
// approximates use-after-free without risking that the memory formerly used
// for the InitializationState object has been repurposed.
// (Though this is still UB and MSan does not like this)
MSAN_UNPOISON(initialization_state, sizeof(*initialization_state));
EXPECT_FALSE(initialization_state->is_uninitialized());
EXPECT_FALSE(initialization_state->is_valid());
}
} // namespace
} // namespace test
} // namespace crashpad