mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 15:50:26 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
85 lines
2.8 KiB
C++
85 lines
2.8 KiB
C++
// Copyright 2018 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "snapshot/fuchsia/memory_map_region_snapshot_fuchsia.h"
|
|
|
|
#include "base/logging.h"
|
|
#include "base/stl_util.h"
|
|
|
|
namespace crashpad {
|
|
namespace internal {
|
|
|
|
namespace {
|
|
|
|
// Maps from bitwise OR of Zircon's flags to enumerated Windows version.
|
|
uint32_t MmuFlagsToProtectFlags(zx_vm_option_t flags) {
|
|
// These bits are currently the lowest 3 of zx_vm_option_t. They're used to
|
|
// index into a mapping array, so make sure that we notice if they change
|
|
// values.
|
|
static_assert(
|
|
ZX_VM_PERM_READ == 1 && ZX_VM_PERM_WRITE == 2 && ZX_VM_PERM_EXECUTE == 4,
|
|
"table below will need fixing");
|
|
|
|
// The entries set to zero don't have good corresponding Windows minidump
|
|
// names. They also aren't currently supported by the mapping syscall on
|
|
// Zircon, so DCHECK that they don't happen in practice. EXECUTE-only also
|
|
// cannot currently happen, but as that has a good mapping to the Windows
|
|
// value, leave it in place in case it's supported by the syscall in the
|
|
// future.
|
|
static constexpr uint32_t mapping[] = {
|
|
/* --- */ PAGE_NOACCESS,
|
|
/* --r */ PAGE_READONLY,
|
|
/* -w- */ 0,
|
|
/* -wr */ PAGE_READWRITE,
|
|
/* x-- */ PAGE_EXECUTE,
|
|
/* x-r */ PAGE_EXECUTE_READ,
|
|
/* xw- */ 0,
|
|
/* xwr */ PAGE_EXECUTE_READWRITE,
|
|
};
|
|
|
|
const uint32_t index =
|
|
flags & (ZX_VM_PERM_READ | ZX_VM_PERM_WRITE | ZX_VM_PERM_EXECUTE);
|
|
DCHECK_LT(index, base::size(mapping));
|
|
|
|
const uint32_t protect_flags = mapping[index];
|
|
DCHECK_NE(protect_flags, 0u);
|
|
return protect_flags;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
MemoryMapRegionSnapshotFuchsia::MemoryMapRegionSnapshotFuchsia(
|
|
const zx_info_maps_t& info_map)
|
|
: memory_info_() {
|
|
DCHECK_EQ(info_map.type, ZX_INFO_MAPS_TYPE_MAPPING);
|
|
|
|
memory_info_.BaseAddress = info_map.base;
|
|
memory_info_.AllocationBase = info_map.base;
|
|
memory_info_.RegionSize = info_map.size;
|
|
memory_info_.State = MEM_COMMIT;
|
|
memory_info_.Protect = memory_info_.AllocationProtect =
|
|
MmuFlagsToProtectFlags(info_map.u.mapping.mmu_flags);
|
|
memory_info_.Type = MEM_MAPPED;
|
|
}
|
|
|
|
MemoryMapRegionSnapshotFuchsia::~MemoryMapRegionSnapshotFuchsia() {}
|
|
|
|
const MINIDUMP_MEMORY_INFO&
|
|
MemoryMapRegionSnapshotFuchsia::AsMinidumpMemoryInfo() const {
|
|
return memory_info_;
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace crashpad
|