3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-01-04 04:35:26 +08:00
Code Issues Projects Releases Wiki Activity
crashpad/util/file/delimited_file_reader_test.cc
Mark Mentovai 51b21d8874 Add DelimitedFileReader and use it in Linux/Android’s ProcessInfo 
This implements a non-stdio-based getline() equivalent. getline() is not
in the Android NDK until API 21 (Android 5.0.0), while Chrome builds for
32-bit platforms with API 16 (Android 4.1.0). Although a getline()
declaration could be provided in compat for use with older NDK headers,
it’s desirable to move away from stdio entirely. The C++
DelimitedFileReader interface is also a bit more comfortable to use than
getline().

A getdelim() equivalent is also provided, and is also used in the
Linux/Android ProcessInfo implementation.

Bug: crashpad:30
Test: crashpad_util_test FileLineReader.*:ProcessInfo.*
Change-Id: Ic1664758a87cfe4953ab22bd3ae190761404b22c
Reviewed-on: https://chromium-review.googlesource.com/455998
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-03-16 17:42:09 +00:00

364 lines
12 KiB
C++
Raw Blame History

// Copyright 2017 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "util/file/delimited_file_reader.h"
#include <vector>
#include "base/format_macros.h"
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
#include "util/file/string_file.h"
namespace crashpad {
namespace test {
namespace {
TEST(DelimitedFileReader, EmptyFile) {
StringFile string_file;
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, EmptyOneLineFile) {
StringFile string_file;
string_file.SetString("\n");
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(string_file.string(), line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, SmallOneLineFile) {
StringFile string_file;
string_file.SetString("one line\n");
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(string_file.string(), line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, SmallOneLineFileWithoutNewline) {
StringFile string_file;
string_file.SetString("no newline");
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(string_file.string(), line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, SmallMultiLineFile) {
StringFile string_file;
string_file.SetString("first\nsecond line\n3rd\n");
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("first\n", line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("second line\n", line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("3rd\n", line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, SmallMultiFieldFile) {
StringFile string_file;
string_file.SetString("first,second field\ntwo lines,3rd,");
DelimitedFileReader delimited_file_reader(&string_file);
std::string field;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim(',', &field));
EXPECT_EQ("first,", field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim(',', &field));
EXPECT_EQ("second field\ntwo lines,", field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim(',', &field));
EXPECT_EQ("3rd,", field);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetDelim(',', &field));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetDelim(',', &field));
}
TEST(DelimitedFileReader, SmallMultiFieldFile_MixedDelimiters) {
StringFile string_file;
string_file.SetString("first,second, still 2nd\t3rd\nalso\tnewline\n55555$");
DelimitedFileReader delimited_file_reader(&string_file);
std::string field;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim(',', &field));
EXPECT_EQ("first,", field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim('\t', &field));
EXPECT_EQ("second, still 2nd\t", field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&field));
EXPECT_EQ("3rd\n", field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim('\n', &field));
EXPECT_EQ("also\tnewline\n", field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim('$', &field));
EXPECT_EQ("55555$", field);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetDelim('?', &field));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&field));
}
TEST(DelimitedFileReader, EmptyLineMultiLineFile) {
StringFile string_file;
string_file.SetString("first\n\n\n4444\n");
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("first\n", line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("\n", line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("\n", line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ("4444\n", line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, LongOneLineFile) {
std::string contents(50000, '!');
contents[1] = '?';
contents.push_back('\n');
StringFile string_file;
string_file.SetString(contents);
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(contents, line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
void TestLongMultiLineFile(int base_length) {
std::vector<std::string> lines;
std::string contents;
for (size_t line_index = 0; line_index <= 'z' - 'a'; ++line_index) {
char c = 'a' + static_cast<char>(line_index);
// Mix up the lengths a little.
std::string line(base_length + line_index * ((line_index % 3) - 1), c);
// Mix up the data a little too.
ASSERT_LT(line_index, line.size());
line[line_index] -= ('a' - 'A');
line.push_back('\n');
contents.append(line);
lines.push_back(line);
}
StringFile string_file;
string_file.SetString(contents);
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
for (size_t line_index = 0; line_index < lines.size(); ++line_index) {
SCOPED_TRACE(base::StringPrintf("line_index %" PRIuS, line_index));
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(lines[line_index], line);
}
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, LongMultiLineFile) {
TestLongMultiLineFile(500);
}
TEST(DelimitedFileReader, ReallyLongMultiLineFile) {
TestLongMultiLineFile(5000);
}
TEST(DelimitedFileReader, EmbeddedNUL) {
const char kString[] = "embedded\0NUL\n";
StringFile string_file;
string_file.SetString(std::string(kString, arraysize(kString) - 1));
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(string_file.string(), line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
TEST(DelimitedFileReader, NULDelimiter) {
const char kString[] = "aa\0b\0ccc\0";
StringFile string_file;
string_file.SetString(std::string(kString, arraysize(kString) - 1));
DelimitedFileReader delimited_file_reader(&string_file);
std::string field;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim('\0', &field));
EXPECT_EQ(std::string("aa\0", 3), field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim('\0', &field));
EXPECT_EQ(std::string("b\0", 2), field);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetDelim('\0', &field));
EXPECT_EQ(std::string("ccc\0", 4), field);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetDelim('\0', &field));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetDelim('\0', &field));
}
TEST(DelimitedFileReader, EdgeCases) {
const size_t kSizes[] = {4094, 4095, 4096, 4097, 8190, 8191, 8192, 8193};
for (size_t index = 0; index < arraysize(kSizes); ++index) {
size_t size = kSizes[index];
SCOPED_TRACE(
base::StringPrintf("index %" PRIuS ", size %" PRIuS, index, size));
std::string line_0(size, '$');
line_0.push_back('\n');
StringFile string_file;
string_file.SetString(line_0);
DelimitedFileReader delimited_file_reader(&string_file);
std::string line;
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(line_0, line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
std::string line_1(size, '@');
line_1.push_back('\n');
string_file.SetString(line_0 + line_1);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(line_0, line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(line_1, line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
line_1[size] = '?';
string_file.SetString(line_0 + line_1);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(line_0, line);
ASSERT_EQ(DelimitedFileReader::Result::kSuccess,
delimited_file_reader.GetLine(&line));
EXPECT_EQ(line_1, line);
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
// The file is still at EOF.
EXPECT_EQ(DelimitedFileReader::Result::kEndOfFile,
delimited_file_reader.GetLine(&line));
}
}
} // namespace
} // namespace test
} // namespace crashpad
Reference in New Issue View Git Blame Copy Permalink