Mark Mentovai 14138936b5 test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX ...

Previously on macOS, the test used an OS-specific library function to
recover the original argc and argv. On Linux/Android, it essentially
reimplemented the very code it was testing, which didn’t make for a very
good test. The new approach is to save argc and argv in main() and base
the comparison on that.

Bug: crashpad:30
Test: crashpad_util_test ProcessInfo.*, crashpad_test_test MainArguments.*
Change-Id: I578abed3b04ae10a22f79a193bbb8b6589276c97
Reviewed-on: https://chromium-review.googlesource.com/456798
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

2017-03-20 17:05:30 +00:00

..

mac

Convert from scoped_ptr to std::unique_ptr

2016-04-25 19:16:26 +00:00

win

Make file_io reads more rational and predictable

2017-03-16 20:07:43 +00:00

errors.cc

Roll DEPS for mini_chromium for updates to base/posix/safe_strerror

2015-06-11 20:25:49 -04:00

errors.h

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

file.cc

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

file.h

Add FileWriteMode::kCreateOrFail

2015-10-07 08:20:55 -04:00

gmock_main.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

gtest_death_check.h

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

gtest_main.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

hex_string_test.cc

Centrally define CPUContextX86::Fsave and fsave↔︎fxsave conversions

2017-02-16 18:26:13 +00:00

hex_string.cc

Centrally define CPUContextX86::Fsave and fsave↔︎fxsave conversions

2017-02-16 18:26:13 +00:00

hex_string.h

Centrally define CPUContextX86::Fsave and fsave↔︎fxsave conversions

2017-02-16 18:26:13 +00:00

main_arguments_test.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

main_arguments.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

main_arguments.h

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

multiprocess_exec_posix.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

multiprocess_exec_test_child.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

multiprocess_exec_test.cc

Make file_io reads more rational and predictable

2017-03-16 20:07:43 +00:00

multiprocess_exec_win.cc

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

multiprocess_exec.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

multiprocess_posix_test.cc

Make file_io reads more rational and predictable

2017-03-16 20:07:43 +00:00

multiprocess_posix.cc

posix: Correctly show the expected exit status in multiprocess tests

2016-06-20 21:08:08 +00:00

multiprocess.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

paths_linux.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

paths_mac.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

paths_test_data_root.txt

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

paths_test.cc

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

paths_win.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

paths.cc

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

paths.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

scoped_temp_dir_posix.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

scoped_temp_dir_test.cc

Add FileWriteMode::kCreateOrFail

2015-10-07 08:20:55 -04:00

scoped_temp_dir_win.cc

Add RandomString() and its test, and use it everywhere it makes sense

2015-11-16 13:39:01 -05:00

scoped_temp_dir.cc

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

scoped_temp_dir.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

test_test.gyp

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

test.gyp

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00