mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 15:50:26 +08:00
00b6442752
ReadFile() attempted to continue reading after a short read. In most cases, this is fine. However, ReadFile() would keep trying to fill a partially-filled buffer until experiencing a 0-length read(), signaling end-of-file. For certain weird file descriptors like terminal input, EOF is an ephemeral condition, and attempting to read beyond EOF doesn’t actually return 0 (EOF) provided that they remain open, it will block waiting for more input. Consequently, ReadFile() and anything based on ReadFile() had an undocumented and quirky interface, which was that any short read that it returned (not an underlying short read) actually indicated EOF. This facet of ReadFile() was unexpected, so it’s being removed. The new behavior is that ReadFile() will return an underlying short read. The behavior of FileReaderInterface::Read() is updated in accordance with this change. Upon experiencing a short read, the caller can determine the best action. Most callers were already prepared for this behavior. Outside of util/file, only crashpad_database_util properly implemented EOF detection according to previous semantics, and adapting it to new semantics is trivial. Callers who require an exact-length read can use the new ReadFileExactly(), or the newly renamed LoggingReadFileExactly() or CheckedReadFileExactly(). These functions will retry following a short read. The renamed functions were previously called LoggingReadFile() and CheckedReadFile(), but those names implied that they were simply wrapping ReadFile(), which is not the case. They wrapped ReadFile() and further, insisted on a full read. Since ReadFile()’s semantics are now changing but these functions’ are not, they’re now even more distinct from ReadFile(), and must be renamed to avoid confusion. Test: * Change-Id: I06b77e0d6ad8719bd2eb67dab93a8740542dd908 Reviewed-on: https://chromium-review.googlesource.com/456676 Reviewed-by: Robert Sesek <rsesek@chromium.org>
250 lines
7.6 KiB
C++
250 lines
7.6 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/file/file_io.h"
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "base/logging.h"
|
|
#include "base/numerics/safe_conversions.h"
|
|
#include "base/strings/utf_string_conversions.h"
|
|
|
|
namespace {
|
|
|
|
bool IsSocketHandle(HANDLE file) {
|
|
if (GetFileType(file) == FILE_TYPE_PIPE) {
|
|
// FILE_TYPE_PIPE means that it's a socket, a named pipe, or an anonymous
|
|
// pipe. If we are unable to retrieve the pipe information, we know it's a
|
|
// socket.
|
|
return !GetNamedPipeInfo(file, NULL, NULL, NULL, NULL);
|
|
}
|
|
return false;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
namespace crashpad {
|
|
|
|
namespace {
|
|
|
|
FileHandle OpenFileForOutput(DWORD access,
|
|
const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
DCHECK(access & GENERIC_WRITE);
|
|
DCHECK_EQ(access & ~(GENERIC_READ | GENERIC_WRITE), 0u);
|
|
|
|
DWORD disposition = 0;
|
|
switch (mode) {
|
|
case FileWriteMode::kReuseOrFail:
|
|
disposition = OPEN_EXISTING;
|
|
break;
|
|
case FileWriteMode::kReuseOrCreate:
|
|
disposition = OPEN_ALWAYS;
|
|
break;
|
|
case FileWriteMode::kTruncateOrCreate:
|
|
disposition = CREATE_ALWAYS;
|
|
break;
|
|
case FileWriteMode::kCreateOrFail:
|
|
disposition = CREATE_NEW;
|
|
break;
|
|
}
|
|
return CreateFile(path.value().c_str(),
|
|
access,
|
|
FILE_SHARE_READ | FILE_SHARE_WRITE,
|
|
nullptr,
|
|
disposition,
|
|
FILE_ATTRIBUTE_NORMAL,
|
|
nullptr);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
const char kNativeReadFunctionName[] = "ReadFile";
|
|
const char kNativeWriteFunctionName[] = "WriteFile";
|
|
|
|
// TODO(scottmg): Handle > DWORD-sized reads and writes if necessary.
|
|
|
|
FileOperationResult ReadFile(FileHandle file, void* buffer, size_t size) {
|
|
DCHECK(!IsSocketHandle(file));
|
|
|
|
while (true) {
|
|
DWORD size_dword = base::checked_cast<DWORD>(size);
|
|
DWORD bytes_read;
|
|
BOOL success = ::ReadFile(file, buffer, size_dword, &bytes_read, nullptr);
|
|
if (!success) {
|
|
if (GetLastError() == ERROR_BROKEN_PIPE) {
|
|
// When reading a pipe and the write handle has been closed, ReadFile
|
|
// fails with ERROR_BROKEN_PIPE, but only once all pending data has been
|
|
// read. Treat this as EOF.
|
|
return 0;
|
|
}
|
|
return -1;
|
|
}
|
|
|
|
CHECK_NE(bytes_read, static_cast<DWORD>(-1));
|
|
DCHECK_LE(bytes_read, size_dword);
|
|
if (bytes_read != 0 || GetFileType(file) != FILE_TYPE_PIPE) {
|
|
// Zero bytes read for a file indicates reaching EOF. Zero bytes read from
|
|
// a pipe indicates only that there was a zero byte WriteFile issued on
|
|
// the other end, so continue reading.
|
|
return bytes_read;
|
|
}
|
|
}
|
|
}
|
|
|
|
FileOperationResult WriteFile(FileHandle file,
|
|
const void* buffer,
|
|
size_t size) {
|
|
// TODO(scottmg): This might need to handle the limit for pipes across a
|
|
// network in the future.
|
|
DWORD size_dword = base::checked_cast<DWORD>(size);
|
|
DWORD bytes_written;
|
|
BOOL rv = ::WriteFile(file, buffer, size_dword, &bytes_written, nullptr);
|
|
if (!rv)
|
|
return -1;
|
|
CHECK_NE(bytes_written, static_cast<DWORD>(-1));
|
|
CHECK_EQ(bytes_written, size_dword);
|
|
return bytes_written;
|
|
}
|
|
|
|
FileHandle OpenFileForRead(const base::FilePath& path) {
|
|
return CreateFile(path.value().c_str(),
|
|
GENERIC_READ,
|
|
FILE_SHARE_READ | FILE_SHARE_WRITE,
|
|
nullptr,
|
|
OPEN_EXISTING,
|
|
0,
|
|
nullptr);
|
|
}
|
|
|
|
FileHandle OpenFileForWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
return OpenFileForOutput(GENERIC_WRITE, path, mode, permissions);
|
|
}
|
|
|
|
FileHandle OpenFileForReadAndWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
return OpenFileForOutput(
|
|
GENERIC_READ | GENERIC_WRITE, path, mode, permissions);
|
|
}
|
|
|
|
FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
|
|
FileHandle file = OpenFileForRead(path);
|
|
PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE)
|
|
<< "CreateFile " << base::UTF16ToUTF8(path.value());
|
|
return file;
|
|
}
|
|
|
|
FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
FileHandle file = OpenFileForWrite(path, mode, permissions);
|
|
PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE)
|
|
<< "CreateFile " << base::UTF16ToUTF8(path.value());
|
|
return file;
|
|
}
|
|
|
|
FileHandle LoggingOpenFileForReadAndWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
FileHandle file = OpenFileForReadAndWrite(path, mode, permissions);
|
|
PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE)
|
|
<< "CreateFile " << base::UTF16ToUTF8(path.value());
|
|
return file;
|
|
}
|
|
|
|
bool LoggingLockFile(FileHandle file, FileLocking locking) {
|
|
DWORD flags =
|
|
(locking == FileLocking::kExclusive) ? LOCKFILE_EXCLUSIVE_LOCK : 0;
|
|
|
|
// Note that the `Offset` fields of overlapped indicate the start location for
|
|
// locking (beginning of file in this case), and `hEvent` must be also be set
|
|
// to 0.
|
|
OVERLAPPED overlapped = {0};
|
|
if (!LockFileEx(file, flags, 0, MAXDWORD, MAXDWORD, &overlapped)) {
|
|
PLOG(ERROR) << "LockFileEx";
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool LoggingUnlockFile(FileHandle file) {
|
|
// Note that the `Offset` fields of overlapped indicate the start location for
|
|
// locking (beginning of file in this case), and `hEvent` must be also be set
|
|
// to 0.
|
|
OVERLAPPED overlapped = {0};
|
|
if (!UnlockFileEx(file, 0, MAXDWORD, MAXDWORD, &overlapped)) {
|
|
PLOG(ERROR) << "UnlockFileEx";
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
|
|
DWORD method = 0;
|
|
switch (whence) {
|
|
case SEEK_SET:
|
|
method = FILE_BEGIN;
|
|
break;
|
|
case SEEK_CUR:
|
|
method = FILE_CURRENT;
|
|
break;
|
|
case SEEK_END:
|
|
method = FILE_END;
|
|
break;
|
|
default:
|
|
NOTREACHED();
|
|
break;
|
|
}
|
|
|
|
LARGE_INTEGER distance_to_move;
|
|
distance_to_move.QuadPart = offset;
|
|
LARGE_INTEGER new_offset;
|
|
BOOL result = SetFilePointerEx(file, distance_to_move, &new_offset, method);
|
|
if (!result) {
|
|
PLOG(ERROR) << "SetFilePointerEx";
|
|
return -1;
|
|
}
|
|
return new_offset.QuadPart;
|
|
}
|
|
|
|
bool LoggingTruncateFile(FileHandle file) {
|
|
if (LoggingSeekFile(file, 0, SEEK_SET) != 0)
|
|
return false;
|
|
if (!SetEndOfFile(file)) {
|
|
PLOG(ERROR) << "SetEndOfFile";
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool LoggingCloseFile(FileHandle file) {
|
|
BOOL rv = CloseHandle(file);
|
|
PLOG_IF(ERROR, !rv) << "CloseHandle";
|
|
return !!rv;
|
|
}
|
|
|
|
FileOffset LoggingFileSizeByHandle(FileHandle file) {
|
|
LARGE_INTEGER file_size;
|
|
if (!GetFileSizeEx(file, &file_size)) {
|
|
PLOG(ERROR) << "GetFileSizeEx";
|
|
return -1;
|
|
}
|
|
return file_size.QuadPart;
|
|
}
|
|
|
|
} // namespace crashpad
|