mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-25 22:30:49 +08:00
dea283a7eb
This CL make the iterators implemented by AnnotationList compliant to the requirements imposed by the C++ standard on input iterators. Change-Id: I263c94a97f5bcd7edd5ef4d8b65fa28b11876974 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5093147 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
344 lines
10 KiB
C++
344 lines
10 KiB
C++
// Copyright 2017 The Crashpad Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "client/annotation.h"
|
|
|
|
#include <algorithm>
|
|
#include <iterator>
|
|
#include <string>
|
|
#include <type_traits>
|
|
#include <vector>
|
|
|
|
#include "base/rand_util.h"
|
|
#include "client/crashpad_info.h"
|
|
#include "gtest/gtest.h"
|
|
#include "util/misc/clock.h"
|
|
#include "util/thread/thread.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
#if (__cplusplus >= 202002L)
|
|
template <typename Iterator>
|
|
requires std::input_iterator<Iterator>
|
|
void VerifyIsInputIterator(Iterator) {}
|
|
#else
|
|
template <typename Iterator>
|
|
struct IsLegacyIteratorImpl {
|
|
static constexpr bool value =
|
|
std::is_copy_constructible_v<Iterator> &&
|
|
std::is_copy_assignable_v<Iterator> && std::is_destructible_v<Iterator> &&
|
|
std::is_swappable_v<Iterator> &&
|
|
// check that std::iterator_traits has the necessary types (check only one
|
|
// needed as std::iterator is required to define only if all are defined)
|
|
!std::is_same_v<typename std::iterator_traits<Iterator>::reference,
|
|
void> &&
|
|
std::is_same_v<decltype(++std::declval<Iterator>()), Iterator&> &&
|
|
!std::is_same_v<decltype(*std::declval<Iterator>()), void>;
|
|
};
|
|
|
|
template <typename Iterator>
|
|
struct IsLegacyInputIteratorImpl {
|
|
static constexpr bool value =
|
|
IsLegacyIteratorImpl<Iterator>::value &&
|
|
std::is_base_of_v<
|
|
std::input_iterator_tag,
|
|
typename std::iterator_traits<Iterator>::iterator_category> &&
|
|
std::is_convertible_v<decltype(std::declval<Iterator>() !=
|
|
std::declval<Iterator>()),
|
|
bool> &&
|
|
std::is_convertible_v<decltype(std::declval<Iterator>() ==
|
|
std::declval<Iterator>()),
|
|
bool> &&
|
|
std::is_same_v<decltype(*std::declval<Iterator>()),
|
|
typename std::iterator_traits<Iterator>::reference> &&
|
|
std::is_same_v<decltype(++std::declval<Iterator>()), Iterator&> &&
|
|
std::is_same_v<decltype(std::declval<Iterator>()++), Iterator> &&
|
|
std::is_same_v<decltype(*(++std::declval<Iterator>())),
|
|
typename std::iterator_traits<Iterator>::reference>;
|
|
};
|
|
|
|
template <typename Iterator>
|
|
void VerifyIsInputIterator(Iterator) {
|
|
static_assert(IsLegacyInputIteratorImpl<Iterator>::value);
|
|
}
|
|
#endif
|
|
|
|
TEST(AnnotationListStatic, Register) {
|
|
ASSERT_FALSE(AnnotationList::Get());
|
|
EXPECT_TRUE(AnnotationList::Register());
|
|
EXPECT_TRUE(AnnotationList::Get());
|
|
EXPECT_EQ(AnnotationList::Get(), AnnotationList::Register());
|
|
|
|
// This isn't expected usage of the AnnotationList API, but it is necessary
|
|
// for testing.
|
|
AnnotationList* list = AnnotationList::Get();
|
|
CrashpadInfo::GetCrashpadInfo()->set_annotations_list(nullptr);
|
|
delete list;
|
|
|
|
EXPECT_FALSE(AnnotationList::Get());
|
|
}
|
|
|
|
class AnnotationList : public testing::Test {
|
|
public:
|
|
void SetUp() override {
|
|
CrashpadInfo::GetCrashpadInfo()->set_annotations_list(&annotations_);
|
|
}
|
|
|
|
void TearDown() override {
|
|
CrashpadInfo::GetCrashpadInfo()->set_annotations_list(nullptr);
|
|
}
|
|
|
|
// NOTE: Annotations should be declared at file-scope, but in order to test
|
|
// them, they are declared as part of the test. These members are public so
|
|
// they are accessible from global helpers.
|
|
crashpad::StringAnnotation<8> one_{"First"};
|
|
crashpad::StringAnnotation<256> two_{"Second"};
|
|
crashpad::StringAnnotation<101> three_{"First"};
|
|
|
|
protected:
|
|
using AllAnnotations = std::vector<std::pair<std::string, std::string>>;
|
|
|
|
AllAnnotations CollectAnnotations() {
|
|
AllAnnotations annotations;
|
|
|
|
for (Annotation* curr : annotations_) {
|
|
if (!curr->is_set())
|
|
continue;
|
|
std::string value(static_cast<const char*>(curr->value()), curr->size());
|
|
annotations.push_back(std::make_pair(curr->name(), value));
|
|
}
|
|
|
|
return annotations;
|
|
}
|
|
|
|
bool ContainsNameValue(const AllAnnotations& annotations,
|
|
const std::string& name,
|
|
const std::string& value) {
|
|
return std::find(annotations.begin(),
|
|
annotations.end(),
|
|
std::make_pair(name, value)) != annotations.end();
|
|
}
|
|
|
|
crashpad::AnnotationList annotations_;
|
|
};
|
|
|
|
TEST_F(AnnotationList, SetAndClear) {
|
|
one_.Set("this is a value longer than 8 bytes");
|
|
AllAnnotations annotations = CollectAnnotations();
|
|
|
|
EXPECT_EQ(1u, annotations.size());
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "First", "this is "));
|
|
|
|
one_.Clear();
|
|
|
|
EXPECT_EQ(0u, CollectAnnotations().size());
|
|
|
|
one_.Set("short");
|
|
two_.Set(std::string(500, 'A').data());
|
|
|
|
annotations = CollectAnnotations();
|
|
EXPECT_EQ(2u, annotations.size());
|
|
|
|
EXPECT_EQ(5u, one_.size());
|
|
EXPECT_EQ(256u, two_.size());
|
|
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "First", "short"));
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "Second", std::string(256, 'A')));
|
|
}
|
|
|
|
TEST_F(AnnotationList, DuplicateKeys) {
|
|
ASSERT_EQ(0u, CollectAnnotations().size());
|
|
|
|
one_.Set("1");
|
|
three_.Set("2");
|
|
|
|
AllAnnotations annotations = CollectAnnotations();
|
|
EXPECT_EQ(2u, annotations.size());
|
|
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "First", "1"));
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "First", "2"));
|
|
|
|
one_.Clear();
|
|
|
|
annotations = CollectAnnotations();
|
|
EXPECT_EQ(1u, annotations.size());
|
|
}
|
|
|
|
TEST_F(AnnotationList, IteratorSingleAnnotation) {
|
|
ASSERT_EQ(annotations_.begin(), annotations_.end());
|
|
ASSERT_EQ(annotations_.cbegin(), annotations_.cend());
|
|
|
|
one_.Set("1");
|
|
|
|
auto iterator = annotations_.begin();
|
|
auto const_iterator = annotations_.cbegin();
|
|
|
|
ASSERT_NE(iterator, annotations_.end());
|
|
ASSERT_NE(const_iterator, annotations_.cend());
|
|
|
|
EXPECT_EQ(*iterator, &one_);
|
|
EXPECT_EQ(*const_iterator, &one_);
|
|
|
|
++iterator;
|
|
++const_iterator;
|
|
|
|
EXPECT_EQ(iterator, annotations_.end());
|
|
EXPECT_EQ(const_iterator, annotations_.cend());
|
|
}
|
|
|
|
TEST_F(AnnotationList, IteratorMultipleAnnotationsInserted) {
|
|
ASSERT_EQ(annotations_.begin(), annotations_.end());
|
|
ASSERT_EQ(annotations_.cbegin(), annotations_.cend());
|
|
|
|
one_.Set("1");
|
|
two_.Set("2");
|
|
|
|
// New annotations are inserted to the beginning of the list. Hence, |two_|
|
|
// must be the first annotation, followed by |one_|.
|
|
{
|
|
auto iterator = annotations_.begin();
|
|
auto const_iterator = annotations_.cbegin();
|
|
|
|
ASSERT_NE(iterator, annotations_.end());
|
|
ASSERT_NE(const_iterator, annotations_.cend());
|
|
|
|
EXPECT_EQ(*iterator, &two_);
|
|
EXPECT_EQ(*const_iterator, &two_);
|
|
|
|
++iterator;
|
|
++const_iterator;
|
|
|
|
ASSERT_NE(iterator, annotations_.end());
|
|
ASSERT_NE(const_iterator, annotations_.cend());
|
|
|
|
EXPECT_EQ(*iterator, &one_);
|
|
EXPECT_EQ(*const_iterator, &one_);
|
|
|
|
++iterator;
|
|
++const_iterator;
|
|
|
|
EXPECT_EQ(iterator, annotations_.end());
|
|
EXPECT_EQ(const_iterator, annotations_.cend());
|
|
}
|
|
}
|
|
|
|
TEST_F(AnnotationList, IteratorMultipleAnnotationsInsertedAndRemoved) {
|
|
ASSERT_EQ(annotations_.begin(), annotations_.end());
|
|
ASSERT_EQ(annotations_.cbegin(), annotations_.cend());
|
|
|
|
one_.Set("1");
|
|
two_.Set("2");
|
|
one_.Clear();
|
|
two_.Clear();
|
|
|
|
// Even after clearing, Annotations are still inserted in the list and
|
|
// reachable via the iterators.
|
|
auto iterator = annotations_.begin();
|
|
auto const_iterator = annotations_.cbegin();
|
|
|
|
ASSERT_NE(iterator, annotations_.end());
|
|
ASSERT_NE(const_iterator, annotations_.cend());
|
|
|
|
EXPECT_EQ(*iterator, &two_);
|
|
EXPECT_EQ(*const_iterator, &two_);
|
|
|
|
++iterator;
|
|
++const_iterator;
|
|
|
|
ASSERT_NE(iterator, annotations_.end());
|
|
ASSERT_NE(const_iterator, annotations_.cend());
|
|
|
|
EXPECT_EQ(*iterator, &one_);
|
|
EXPECT_EQ(*const_iterator, &one_);
|
|
|
|
++iterator;
|
|
++const_iterator;
|
|
|
|
EXPECT_EQ(iterator, annotations_.end());
|
|
EXPECT_EQ(const_iterator, annotations_.cend());
|
|
}
|
|
|
|
TEST_F(AnnotationList, IteratorIsInputIterator) {
|
|
one_.Set("1");
|
|
two_.Set("2");
|
|
|
|
// Check explicitly that the iterators meet the interface of an input
|
|
// iterator.
|
|
VerifyIsInputIterator(annotations_.begin());
|
|
VerifyIsInputIterator(annotations_.cbegin());
|
|
VerifyIsInputIterator(annotations_.end());
|
|
VerifyIsInputIterator(annotations_.cend());
|
|
|
|
// Additionally verify that std::distance accepts the iterators. It requires
|
|
// the iterators to comply to the input iterator interface.
|
|
EXPECT_EQ(std::distance(annotations_.begin(), annotations_.end()), 2);
|
|
EXPECT_EQ(std::distance(annotations_.cbegin(), annotations_.cend()), 2);
|
|
}
|
|
|
|
class RaceThread : public Thread {
|
|
public:
|
|
explicit RaceThread(test::AnnotationList* test) : Thread(), test_(test) {}
|
|
|
|
private:
|
|
void ThreadMain() override {
|
|
for (int i = 0; i <= 50; ++i) {
|
|
if (i % 2 == 0) {
|
|
test_->three_.Set("three");
|
|
test_->two_.Clear();
|
|
} else {
|
|
test_->three_.Clear();
|
|
}
|
|
SleepNanoseconds(base::RandInt(1, 1000));
|
|
}
|
|
}
|
|
|
|
test::AnnotationList* test_;
|
|
};
|
|
|
|
TEST_F(AnnotationList, MultipleThreads) {
|
|
ASSERT_EQ(0u, CollectAnnotations().size());
|
|
|
|
RaceThread other_thread(this);
|
|
other_thread.Start();
|
|
|
|
for (int i = 0; i <= 50; ++i) {
|
|
if (i % 2 == 0) {
|
|
one_.Set("one");
|
|
two_.Set("two");
|
|
} else {
|
|
one_.Clear();
|
|
}
|
|
SleepNanoseconds(base::RandInt(1, 1000));
|
|
}
|
|
|
|
other_thread.Join();
|
|
|
|
AllAnnotations annotations = CollectAnnotations();
|
|
EXPECT_GE(annotations.size(), 2u);
|
|
EXPECT_LE(annotations.size(), 3u);
|
|
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "First", "one"));
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "First", "three"));
|
|
|
|
if (annotations.size() == 3) {
|
|
EXPECT_TRUE(ContainsNameValue(annotations, "Second", "two"));
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|