mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
e04194afd9
TerminateProcess(), like most of the Windows API, is declared WINAPI, which is __stdcall on 32-bit x86. That means that the callee, TerminateProcess() itself, is responsible for cleaning up parameters on the stack on return. In https://crashpad.chromium.org/bug/179, crashes in ExceptionHandlerServer::OnNonCrashDumpEvent() were observed in ways that make it evident that TerminateProcess() has been patched with a __cdecl routine. The crucial difference between __stdcall and __cdecl is that the caller is responsible for stack parameter cleanup in __cdecl. The mismatch means that nobody cleans parameters from the stack, and the stack pointer has an unexpected value, which in the case of the Crashpad handler crash, results in TerminateProcess()’s second argument erroneously being used as the lock address in the call to ReleaseSRWLockExclusive() or LeaveCriticalSection(). As a workaround, on 32-bit x86, call through SafeTerminateProcess(), a custom assembly routine that’s compatible with either __stdcall or __cdecl implementations of TerminateProcess() by not trusting the value of the stack pointer on return from that function. Instead, the stack pointer is restored directly from the frame pointer. Bug: crashpad:179 Test: crashpad_util_test SafeTerminateProcess.*, others Change-Id: If9508f4eb7631020ea69ddbbe4a22eb335cdb325 Reviewed-on: https://chromium-review.googlesource.com/481180 Reviewed-by: Scott Graham <scottmg@chromium.org>
38 lines
1.4 KiB
C++
38 lines
1.4 KiB
C++
// Copyright 2016 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_UTIL_WIN_TERMINATION_CODES_H_
|
|
#define CRASHPAD_UTIL_WIN_TERMINATION_CODES_H_
|
|
|
|
namespace crashpad {
|
|
|
|
//! \brief Crashpad-specific codes that are used as arguments to
|
|
//! SafeTerminateProcess() or `TerminateProcess()` in unusual circumstances.
|
|
enum TerminationCodes : unsigned int {
|
|
//! \brief The crash handler did not respond, and the client self-terminated.
|
|
kTerminationCodeCrashNoDump = 0xffff7001,
|
|
|
|
//! \brief The initial process snapshot failed, so the correct client
|
|
//! termination code could not be retrieved.
|
|
kTerminationCodeSnapshotFailed = 0xffff7002,
|
|
|
|
//! \brief A dump was requested for a client that was never registered with
|
|
//! the crash handler.
|
|
kTerminationCodeNotConnectedToHandler = 0xffff7003,
|
|
};
|
|
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_UTIL_WIN_TERMINATION_CODES_H_
|